Closed Bug 74866 Opened 24 years ago Closed 24 years ago

|nsPromiseFlat[C]String| doesn't forward enough functions when attached to a rickg string instance

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla0.9

People

(Reporter: scc, Assigned: scc)

References

Details

Attachments

(2 files)

most of the functions handled in |nsAFlat[C]String| are predicated on the notion that buffer handles work and the string pointed to uses them. This is not the case when pointing at a rickg string. More forwarding is required.
- protected: +// protected: + public: You obviously (?) want to make this protected, but can't: can you add a comment as to why it a) should be protected, and b) isn't? Man, am I ever not going to miss obsolete/nsString. sr=shaver, if you add that comment.
Attached patch addressing shaver's comments (deleted) — Splinter Review
Blocks: 70090
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
r=dbaron. Using char_type in some places and the real char type in others seems a bit weird, and also making GetWritableFragment public doesn't seem necessary at the moment, but since both are in flux right now I don't think either is a problem...
fix checked in ... btw, we'll be eliminating |char_type| and similar constructs (only present to make copy/paste editing easier), since people have told me that seeing the native types makes it easier to read
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Component: String → XPCOM
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: