Closed
Bug 749548
Opened 13 years ago
Closed 13 years ago
IEProfileMigrator.js and SafariProfileMigrator.js are always in the components manifest
Categories
(Firefox :: Migration, defect)
Tracking
()
RESOLVED
FIXED
Firefox 15
Tracking | Status | |
---|---|---|
firefox12 | --- | unaffected |
firefox13 | --- | unaffected |
firefox14 | --- | affected |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mak
:
review+
akeybl
:
approval-mozilla-aurora-
|
Details | Diff | Splinter Review |
On Mac, there is no IEProfileMigrator.js.
On Linux, there is neither.
Yet, in both builds, they both are in the components manifest.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → mh+mozilla
status-firefox12:
--- → unaffected
status-firefox13:
--- → unaffected
status-firefox14:
--- → affected
Assignee | ||
Comment 1•13 years ago
|
||
Comment 2•13 years ago
|
||
Comment on attachment 618955 [details] [diff] [review]
Only reference IE and Safari migrators in components manifest when they are installed
Review of attachment 618955 [details] [diff] [review]:
-----------------------------------------------------------------
should be safe to backport to 13 too, so please get approval and do :)
Attachment #618955 -
Flags: review+
Assignee | ||
Comment 3•13 years ago
|
||
Target Milestone: --- → Firefox 15
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 5•13 years ago
|
||
The commit message is misleading because we can't detect "when they are installed" at build time. Something like this would be better:
"Only reference IE and Safari migrators in components manifest on supported operating systems."
Assignee | ||
Comment 6•13 years ago
|
||
It's "installed" in the "$(NSINSTALL)" sense.
Comment 7•13 years ago
|
||
(In reply to Marco Bonardo [:mak] from comment #2)
> should be safe to backport to 13 too, so please get approval and do :)
I actually meant "backport to 14"... Merge didn't help my numbering.
Assignee | ||
Comment 8•13 years ago
|
||
Comment on attachment 618955 [details] [diff] [review]
Only reference IE and Safari migrators in components manifest when they are installed
[Approval Request Comment]
Regression caused by: bug 710259 and bug 710895
User impact if declined: No real user impact, but Firefox uselessly tries to registers components that aren't there on Mac and Linux.
Testing completed (on m-c, etc.): Landed on m-c a couple days ago.
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
Attachment #618955 -
Flags: approval-mozilla-aurora?
Comment 9•13 years ago
|
||
Comment on attachment 618955 [details] [diff] [review]
Only reference IE and Safari migrators in components manifest when they are installed
[Triage Comment]
We don't typically take correctness fixes with no user impact.
Attachment #618955 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
You need to log in
before you can comment on or make changes to this bug.
Description
•