Closed
Bug 749626
Opened 12 years ago
Closed 12 years ago
Theme update: make the close button code generic and implement the dark theme for menulists.
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 15
People
(Reporter: paul, Assigned: paul)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file, 5 obsolete files)
(deleted),
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
3 different patches need these changes.
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → paul
Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•12 years ago
|
||
Here is some code to test: let menulist = document.createElement("menulist"); menulist.className = "devtools-menulist"; let menupopup = document.createElement("menupopup"); menulist.appendChild(menupopup); let i1 = document.createElement("menuitem"); let i2 = document.createElement("menuitem"); i1.setAttribute("label", "foo"); i2.setAttribute("label", "foo foo bar bar"); menupopup.appendChild(i1); menupopup.appendChild(i2); InspectorUI.toolbar.appendChild(menulist); Copy/paste in scratchpad (browser mode). Run with the Inspector open.
Assignee | ||
Comment 3•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #619039 -
Attachment is obsolete: true
Assignee | ||
Comment 4•12 years ago
|
||
osx style
Assignee | ||
Updated•12 years ago
|
Attachment #620360 -
Attachment is obsolete: true
Assignee | ||
Comment 5•12 years ago
|
||
Windows style (includes a fix for some the breadcrumbs)
Assignee | ||
Updated•12 years ago
|
Attachment #620731 -
Attachment is obsolete: true
Assignee | ||
Comment 6•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #621542 -
Attachment is obsolete: true
Assignee | ||
Comment 7•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #621555 -
Attachment is obsolete: true
Assignee | ||
Comment 8•12 years ago
|
||
Comment on attachment 621600 [details] [diff] [review] patch v1 This patch includes: - shared close button style - fix for the searchinput style - menulist style - fix some misalignment and focus-ring problems of the breadcrumbs on Windows
Attachment #621600 -
Flags: review?(dao)
Assignee | ||
Comment 9•12 years ago
|
||
review ping
Updated•12 years ago
|
Attachment #621600 -
Flags: review?(dao) → review+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
Assignee | ||
Comment 10•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2707febfc98f
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2707febfc98f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•