See bug 749312 - it would be convenient to stop having to ship tarballs of source on our FTP server. This in no way changes Mozilla's commitment to provide source to its products - it's just that tarballs of each version are a very inefficient way of doing it, and the MPL 2 has been given additional flexibility over MPL 1.1 that we should take advantage of. The MPL 2's requirements on this are in sections 3.1 and 3.2. By design :-), they are not onerous to comply with. 3.2: "You must inform recipients of the Executable Form how they can obtain a copy of such Source Code Form by reasonable means in a timely manner, at a charge no more than the cost of distribution to the recipient". At the bottom of the About box, we link to "Licensing Information", which takes you to about:license. We should update the blurb at the top of about:license to give the necessary Hg URL alongside the download instructions. That meets MPL 2's requirements. Gerv

Here's a patch. Gerv

Comment on attachment 619594 [details] [diff] [review] Patch v.1 Requesting sanity check from Luis. Gerv

Comment on attachment 619594 [details] [diff] [review] Patch v.1 Review of attachment 619594 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/content/license.html @@ +34,5 @@ > <a href="http://www.gnu.org/philosophy/free-sw.html">free</a> and > <a href="http://www.opensource.org/docs/definition.php">open source</a>. > +#ifdef SOURCE_REPO > +#ifdef SOURCE_CHANGESET > +The specific source code is identified by the URL <a href="@SOURCE_REPO@/rev/@SOURCE_CHANGESET@">@SOURCE_REPO@/rev/@SOURCE_CHANGESET@</a>, I would say "specific source code _for this product_." Otherwise, looks good.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ebceb5cac17 Gerv

Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/15.0 Firefox/15.0a1 2012-05-03 Nightly There are 2 problems here: 1. You've added a random "h" to the beginning of about:license. 2. This patch doesn't actually work (at least, I don't see anything from the #ifdef block). As this is more than a text change it should have a code review as well. I think this should be backed out until a new patch has been created and properly reviewed.

AIUI, you may not necessarily see anything in a self-built build; it may be that those params are only defined for more official builds. I used the code from about:buildconfig. Do you see an Hg URL there? If you do, but not one in about:license, then it's broken. Do jump on to IRC to chat about it. I'm not opposed to backing it out, but I want to make sure it's actually broken first :-) The "h" is clearly a mistake, easily fixed. Gerv

(In reply to Gervase Markham [:gerv] from comment #7) > AIUI, you may not necessarily see anything in a self-built build; it may be > that those params are only defined for more official builds. I used the code > from about:buildconfig. Do you see an Hg URL there? If you do, but not one > in about:license, then it's broken. Yes, in about:buildconfig is see: "Built from http://hg.mozilla.org/mozilla-central/rev/807403a04a6a" This is Nightly build from Mozilla (see "2012-05-03 Nightly" in comment 6), not self-built.

Hmm. Clearly the preprocessor does not work as simply as I thought. I would back it out, but mozilla-inbound is currently closed. In the mean time, I'll try and get it working. Gerv

See also bug 751599. Gerv

(In reply to Gervase Markham [:gerv] from comment #7) > AIUI, you may not necessarily see anything in a self-built build; it may be > that those params are only defined for more official builds. I used the code > from about:buildconfig. Do you see an Hg URL there? If you do, but not one > in about:license, then it's broken. > > Do jump on to IRC to chat about it. I'm not opposed to backing it out, but I > want to make sure it's actually broken first :-) > > The "h" is clearly a mistake, easily fixed. > > Gerv Bug 754912 fixed the "h" problem. I still think that this should be backed out because it is unreviewed and doesn't work.

Backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/0cbcefdd3c48 Gerv

Here is a version which does not require the preprocessor. That's much better than nothing, and avoids the tarpit that is bug 751599. Gerv

Unbitrotted. djcater seems to have gone. This patch no longer contains a code component, so I am just going to check it in. Gerv

https://hg.mozilla.org/integration/mozilla-inbound/rev/d742d927b9e8 Gerv