George Wright (:gw280) (needinfo me!) Reporter
	Description • 12 years ago

Tiled Thebes Layers should have support for drawing using Azure DrawTargets

	Benoit Girard (:BenWa)
	Comment 2 • 12 years ago

Comment on attachment 619656 [details] [diff] [review]
Add support for Azure content rendering to BasicTiledThebesLayer

Looks good

	George Wright (:gw280) (needinfo me!) Reporter
	Comment 3 • 12 years ago

Updated patch. Instead of using Thebes' API to copy the surface to the other, we use Azure directly now.

	George Wright (:gw280) (needinfo me!) Reporter
	Comment 5 • 12 years ago

Just a quick update as to why this hasn't landed; I need to land the patches for bug 740580 first, and they broke a reftest on unaccelerated windows, which I have yet to fix.

	Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e) Assignee
	Comment 6 • 12 years ago

Simple rebasing so it should not require re-review.

	Mozilla RelEng Bot
	Comment 7 • 12 years ago

Try run for c4c5d3796da0 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c4c5d3796da0
Results (out of 92 total builds):
    exception: 3
    success: 73
    warnings: 16
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-c4c5d3796da0

	Benoit Girard (:BenWa)
	Comment 9 • 12 years ago

Comment on attachment 665777 [details] [diff] [review]
Add support for Azure content rendering to BasicTiledThebesLayer

Review of attachment 665777 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM with this fixed

::: gfx/layers/basic/BasicTiledThebesLayer.cpp
@@ +179,5 @@
>    // Bug 742100, this gfxContext really should live on the stack.
> +  nsRefPtr<gfxContext> ctxt;
> +
> +  RefPtr<gfx::DrawTarget> writableDrawTarget;
> +  if (gfxPlatform::GetPlatform()->SupportsAzureContent()) {

This only needs to happen if we're doing a single paint buffer draw.

	Benoit Girard (:BenWa)
	Comment 10 • 12 years ago

Comment on attachment 661087 [details] [diff] [review]
Azure content for BasicTiledThebesLayer

This is stuck in my review queue so I'm removing this.

	Mozilla RelEng Bot
	Comment 11 • 12 years ago

Try run for c688628b3c28 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c688628b3c28
Results (out of 90 total builds):
    success: 83
    warnings: 7
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-c688628b3c28

	Mozilla RelEng Bot
	Comment 12 • 12 years ago

Try run for c688628b3c28 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c688628b3c28
Results (out of 91 total builds):
    success: 83
    warnings: 8
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-c688628b3c28

	Mozilla RelEng Bot
	Comment 13 • 12 years ago

Try run for c688628b3c28 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c688628b3c28
Results (out of 92 total builds):
    success: 84
    warnings: 8
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-c688628b3c28

	Ryan VanderMeulen [:RyanVM]
	Comment 14 • 12 years ago

This is bitrotted. Please rebase.

	Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e) Assignee
	Comment 15 • 12 years ago

Oops checkin-needed on the wrong bug.

	Matt Woodrow (:mattwoodrow)
	Comment 17 • 11 years ago

Comment on attachment 790002 [details] [diff] [review]
Add support for Azure content rendering to ClientTiledThebesLayer

Review of attachment 790002 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/TiledContentClient.cpp
@@ +236,5 @@
> +  RefPtr<gfx::DrawTarget> writableDrawTarget;
> +  if (gfxPlatform::GetPlatform()->SupportsAzureContent()) {
> +    // TODO: Instead of creating a gfxImageSurface to back the tile we should
> +    // create an offscreen DrawTarget. This would need to be shared cross-thread
> +    // and support copy on write semantics.

I think this comment should go away, since we've done it.

	Matt Woodrow (:mattwoodrow)
	Comment 18 • 11 years ago

Fixed some crash bugs in the Azure paths.

	Matt Woodrow (:mattwoodrow)
	Comment 21 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=dd6769d7adee

	Matt Woodrow (:mattwoodrow)
	Comment 23 • 11 years ago

Carrying forward r=mattwoodrow,BenWa

	Matt Woodrow (:mattwoodrow)
	Comment 24 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/c10b4aed7ae1
https://hg.mozilla.org/integration/mozilla-inbound/rev/b302af041108

	Matt Woodrow (:mattwoodrow)
	Comment 25 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb63634e40c5

	Matt Woodrow (:mattwoodrow)
	Comment 26 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/61ee1063e5af

	Carsten Book [:Tomcat]
	Comment 27 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/c10b4aed7ae1
https://hg.mozilla.org/mozilla-central/rev/b302af041108
https://hg.mozilla.org/mozilla-central/rev/bb63634e40c5
https://hg.mozilla.org/mozilla-central/rev/61ee1063e5af