We want to add known settings to the DB during the gecko build with some xpcom magic.

Todo: cleanup connect it to the build process get a list of settings we want to add

Some Cleanup

Comment on attachment 620018 [details] [diff] [review] WiP: Write settings into DB Review of attachment 620018 [details] [diff] [review]: ----------------------------------------------------------------- Looks like a good start to me. I guess the remaining pieces are to get the b2g build system to copy the indexedDB generated to the device?

(In reply to Fabrice Desré [:fabrice] from comment #4) > Comment on attachment 620018 [details] [diff] [review] > WiP: Write settings into DB > > Review of attachment 620018 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks like a good start to me. > I guess the remaining pieces are to get the b2g build system to copy the > indexedDB generated to the device? Yes exactly. Cjones: what's a reasonable approach here? Always overwrite the DB when flashing, make a new build target and let the user decide? Test if the DB is there and only push when there is no DB?

One thing that I don't like too much, is that the settings list is embedded in the generation script. It would be nice to host it outside.

I guess the best solution here, which would probably be hard to implement with IDB, would be to have "default" settings (~all.js + [frontend].js), which are overridden with user settings (~prefs.js). But I don't think we have a sane way to implement that. We can carry on the discussion wrt b2g build system in the b2g repo, but - make flash must always install the pre-filled settings DB - make install-gecko should IMHO always blow away the DB. We'll lose customizations sometimes, but I think the potential confusion over making settings-related changes and them not propagating to device is too high. - make install-gaia doesn't need to touch settings. We can reuse some of kinds of build hackery we use for gaia to implement this.

update