Closed
Bug 750808
Opened 13 years ago
Closed 13 years ago
formatAccessKey method of text.xml#label-control removes <children> element
Categories
(Toolkit :: XUL Widgets, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: enndeakin, Assigned: enndeakin)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
The line
afterLabel.textContent = "";
causes the anonymous content including the <children> element to be removed. This causes problems with the patch in bug 653881 as this handles insertion points and default content differently.
A simple fix is to just move the <children> element outside of the <span>.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → enndeakin
Attachment #619983 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #620291 -
Flags: review?(neil)
Comment 2•13 years ago
|
||
Comment on attachment 620291 [details] [diff] [review]
updated patch with fixed test
The old binding really confuses DOM Inspector, it doesn't seem to know what's going on ;-)
>+<?xml-stylesheet href="data:text/css,k { display: inline; text-decoration: underline; }" type="text/css"?>
u would be too confusing, I suppose?
+ <label control="b5" maxwidth="50">Quite a <k>l</k>ong label. Hopefully it will wrap"</label><textbox id="b5" label="Button5" size="2"/>
Nit (×4): was the " after wrap an oversight?
>\ No newline at end of file
Nit (×2)
>- <html:span anonid="accessKeyParens"><children/></html:span>
>+ <children/><html:span anonid="accessKeyParens"></html:span>
Remove the comment about setting .textContent too, I guess?
Attachment #620291 -
Flags: review?(neil) → review+
Comment 3•13 years ago
|
||
Please can you set the milestone when landing on inbound. Thank you :-)
https://hg.mozilla.org/mozilla-central/rev/d3733e739f16
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Assignee | ||
Updated•13 years ago
|
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•