Closed
Bug 751291
Opened 13 years ago
Closed 13 years ago
Rename CryptoUtils._sha1 to CryptoUtils.UTF8AndSHA1
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: gps, Assigned: gps)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
(deleted),
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
AITC (and likely others) need a "public" API to access the raw bytes of a SHA-1 hash.
Attachment #620414 -
Flags: review?(rnewman)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 620414 [details] [diff] [review]
Rename _sha1
Review of attachment 620414 [details] [diff] [review]:
-----------------------------------------------------------------
::: services/crypto/modules/utils.js
@@ +54,5 @@
> + /**
> + * UTF-8 encode a message and perform a SHA-1 over it.
> + *
> + * @param message
> + * (string) Buffer to perform operation on.
Add a little clarity here about what exactly is in the buffer -- a JS string? A JS string representing an array of bytes?
Attachment #620414 -
Flags: review?(rnewman) → review+
|
|
||
Updated•13 years ago
|
Assignee: nobody → gps
Status: NEW → ASSIGNED
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → NEW
Whiteboard: [fixed in services]
|
|
||
Updated•13 years ago
|
Status: NEW → ASSIGNED
|
||
Updated•13 years ago
|
Whiteboard: [fixed in services] → [fixed in services][qa-]
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services][qa-] → [qa-]
Target Milestone: --- → mozilla15
|
||
Updated•6 years ago
|
Component: Firefox Sync: Crypto → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•