Closed
Bug 751378
Opened 12 years ago
Closed 12 years ago
Look into removing CAPS strings from stringbundle
Categories
(Core :: Security: CAPS, defect)
Core
Security: CAPS
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: bholley, Assigned: Cykesiopka)
References
Details
(Whiteboard: [mentor=bholley])
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
||
Updated•12 years ago
|
Component: Canvas: 2D → Security: CAPS
QA Contact: canvas.2d → caps
|
Reporter | |
Updated•12 years ago
|
Whiteboard: [mentor=bholley]
|
|
Assignee | |
Comment 1•12 years ago
|
||
From what I can tell, "Yes" and "ExtensionCapability" are only used in test-app-strings.js.
I didn't think it would be necessary to keep the two strings around just for one test, so I chose what I thought would be suitable replacements...
Attachment #722600 -
Flags: review?(bzbarsky)
|
|
||
Comment 2•12 years ago
|
||
Comment on attachment 722600 [details] [diff] [review]
Proposed Patch
Why do we need to keep around CheckMessage?
r=me modulo that.
Attachment #722600 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #2)
> Comment on attachment 722600 [details] [diff] [review]
> Proposed Patch
>
> Why do we need to keep around CheckMessage?
>
> r=me modulo that.
It's used here:
https://mxr.mozilla.org/mozilla-central/source/security/manager/pki/resources/content/clientauthask.js#27
|
||
Comment 5•12 years ago
|
||
Assignee: nobody → cykesiopka
Keywords: checkin-needed
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Blocks: 851007
|
||
Comment 7•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/e58b0d16fb226db9513814c5d288c313ad72f76f
Bug 751378 - Remove unused CAPS strings from stringbundle. r=bz
|
|
||
Comment 8•12 years ago
|
||
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/78a193e577555d2915206a235dbd6c6f65ed2782
Bug 751378 - Remove unused CAPS strings from stringbundle to fix bug 851007. r=bz
(cherry picked from commit e58b0d16fb226db9513814c5d288c313ad72f76f)
|
|
||
Comment 9•12 years ago
|
||
Commit pushed to integration at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/e58b0d16fb226db9513814c5d288c313ad72f76f
Bug 751378 - Remove unused CAPS strings from stringbundle. r=bz
You need to log in
before you can comment on or make changes to this bug.
Description
•