Closed
Bug 75164
Opened 24 years ago
Closed 23 years ago
[tracking bug] work on |ReplaceSubstring|
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: scc, Assigned: scc)
References
Details
Attachments
(5 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
rickg's |ReplaceSubstring| has never worked and now people are starting to
complain. This bug is to track work done to resolve this situation.
|
Assignee | |
Comment 1•23 years ago
|
||
|
|
Assignee | |
Comment 2•23 years ago
|
||
|
|
Assignee | |
Comment 3•23 years ago
|
||
|
||
Comment 4•23 years ago
|
||
+ /* mutable */ int mNumberOfMatches;
PRIn32 ?
+ int N = mNumberOfMatches;
Ditto. |N| risks collision with macros; use longer name?
+ long changePerReplacement = long(mReplacement.Length()) -
long(mPattern.Length());
PRInt32 again?
|
|
Assignee | |
Comment 5•23 years ago
|
||
|
|
Assignee | |
Comment 6•23 years ago
|
||
|
|
||
Comment 7•23 years ago
|
||
I like that one. sr=sfraser
|
|
Assignee | |
Comment 8•23 years ago
|
||
The fix to this bug is that we're going to replace the entire implementation of
|ReplaceSubstring| with the new |nsSubstituteC?String| generator (the
implementation of which was introduced right here in this bug :-). See bug
#82456 for details of making everyone use the new machinery.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Updated•4 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•