Closed Bug 752108 Opened 13 years ago Closed 12 years ago

ENH: simple-prefs, add a "" event, to listen to all pref changes

Categories

(Add-on SDK Graveyard :: General, enhancement, P2)

Product:
Add-on SDK Graveyard
Component:
General
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: glind, Assigned: glind)

References

Details

Attachments

(1 file)

Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/439
(deleted), text/html
evold
: review+
Details
Patch inbound at Github.
Severity: normal → enhancement
Priority: -- → P2
New patch at github.
Hey Gregg, Sorry it took so long to get to this. I'm not sure if you've tried https://addons.mozilla.org/en-US/firefox/addon/github-tweaks-for-bugzilla/ before, but it is a very useful way of attaching github pull requests to bugzilla bugs. Once you do this you can easily request a review or feedback. One issue I have is that I'd prefer "" instead of "*" but let's see what others think.
Assignee: nobody → glind
OS: Mac OS X → All
Hardware: x86 → All
No rush :) '*' is chosen to be symmetric with ObserverService, and to imply that you really are doing something actively, and not by accident. Empty string seems like the sort of thing that can happen accidentally. I will install the tweaks.
Summary: ENH: simple-prefs, add a "*" event, to listen to all pref changes → ENH: simple-prefs, add a "" event, to listen to all pref changes
Gregg, Just two small things to do and it's ready, Thanks!
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/285c0007707d1b86e61313dee318716b0e01eb03 wildcard (empty-string) emitter for simple-prefs bug #752108 (tests, docs, code) All tests pass. https://github.com/mozilla/addon-sdk/commit/ff28559c17a98b6e27eb68bb145ae273c7573cf8 Merge pull request #439 from gregglind/prefswildcard_v2_752108 Fix Bug 752108 Prefswildcard r=@erikvold
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 671541 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/439 ><!DOCTYPE html><meta charset="utf-8"><meta http-equiv="refresh" content="5;https://github.com/mozilla/addon-sdk/pull/439"><title>Bugzilla Code Review</title><p>You can review this patch at <a href="https://github.com/mozilla/addon-sdk/pull/439">https://github.com/mozilla/addon-sdk/pull/439</a>, or wait 5 seconds to be redirected there automatically.</p>
Attachment #671541 - Flags: review?(evold) → review+
Commits pushed to stabilization at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/285c0007707d1b86e61313dee318716b0e01eb03 wildcard (empty-string) emitter for simple-prefs bug #752108 https://github.com/mozilla/addon-sdk/commit/ff28559c17a98b6e27eb68bb145ae273c7573cf8 Merge pull request #439 from gregglind/prefswildcard_v2_752108
Commits pushed to release at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/285c0007707d1b86e61313dee318716b0e01eb03 wildcard (empty-string) emitter for simple-prefs bug #752108 https://github.com/mozilla/addon-sdk/commit/ff28559c17a98b6e27eb68bb145ae273c7573cf8 Merge pull request #439 from gregglind/prefswildcard_v2_752108
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: