Closed Bug 752834 Opened 13 years ago Closed 12 years ago

UI tweaks for the property view

Categories

(DevTools :: Debugger, defect, P2)

Product:
DevTools
Component:
Debugger
Version:
12 Branch
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 15

People

(Reporter: vporof, Assigned: vporof)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 5 obsolete files)

v3
(deleted), patch
past
: review+
Details | Diff | Splinter Review
It's bad to assume someone is interested in EVERYTHING that's shown in the property view. For example, we probably never really need to look at __proto__, but now it's the first element shown and it even has the same colors. Let's reduce visual clutter, by playing with ordering and css a bit.
Status: NEW → ASSIGNED
Also, we're displaying [object Constructor] for everything except primitives (or strings and null). Again, clutter. I think the Constructor information is more than enough.
We should also have nicer property name displays for Arguments, Array and Object types, like Firebug does. Followup bug for this.
Priority: -- → P2
Depends on: 753332
Filed bug 753332 addressing comment #1 and #2.
Blocks: 753332
No longer depends on: 753332
Depends on: 753651
Depends on: 753313
No longer depends on: 753651
Attached patch v1 (obsolete) (deleted) — — Splinter Review
Also fixed some bad indents in DVF_updateState from the debugger xulification.
Attachment #622800 - Flags: review?(rcampbell)
Attached patch v1 (obsolete) (deleted) — — Splinter Review
Had to rebase, since bug 753313 is trending right now.
Attachment #622800 - Attachment is obsolete: true
Attachment #622800 - Flags: review?(rcampbell)
Attachment #622824 - Flags: review?(rcampbell)
Somewhat dependent on bug 752770. Please postpone review until that settles.
Comment on attachment 622824 [details] [diff] [review] v1 + aCallback && aCallback(prop, value); are we doing this now? I guess that's ok.
I'd like to try this out, I would. But the patch depth is too deep.
No longer blocks: 753332
No longer depends on: 753313
Blocks: 753332
Depends on: 753313
Attached patch v1.1 (obsolete) (deleted) — — Splinter Review
Rebased.
Attachment #622824 - Attachment is obsolete: true
Attachment #622824 - Flags: review?(rcampbell)
Attachment #625517 - Flags: review?(rcampbell)
Attached patch v2 (obsolete) (deleted) — — Splinter Review
Rebased.
Attachment #625517 - Attachment is obsolete: true
Attachment #625517 - Flags: review?(rcampbell)
Attachment #627727 - Flags: review?(rcampbell)
Attached patch v2 (obsolete) (deleted) — — Splinter Review
Achievement unlocked: forgot to qref.
Attachment #627727 - Attachment is obsolete: true
Attachment #627727 - Flags: review?(rcampbell)
Attachment #627728 - Flags: review?(rcampbell)
Blocks: 759135
Attached patch v3 (deleted) — — Splinter Review
Bug 755346 generated a lot of fuzz, qrefreshed.
Comment on attachment 627935 [details] [diff] [review] v3 ok. Let me try this.
Attachment #627728 - Flags: review?(rcampbell)
Attachment #627728 - Attachment is obsolete: true
Comment on attachment 627935 [details] [diff] [review] v3 Review of attachment 627935 [details] [diff] [review]: ----------------------------------------------------------------- Got a call from the Homeowners Association that I should help the homeless, so I'm stealing this. Looks good.
Attachment #627935 - Flags: review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/71f26fd0bdc5
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/71f26fd0bdc5
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: