Closed
Bug 753012
Opened 13 years ago
Closed 13 years ago
B2G SMS: wrong calculated encoding value for dcs = 0xF?
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: vicamo, Assigned: vicamo)
References
Details
Attachments
(1 file)
(deleted),
patch
|
philikon
:
review+
|
Details | Diff | Splinter Review |
See 3GPP TS 23.038 clause 5 "CBS Data Coding Scheme", the encoding shall be 8-bit if bit 2 is on, but code in ril_worker.js does otherwise: > if (!dcs & 0x04) { > encoding = PDU_DCS_MSG_CODING_8BITS_ALPHABET; > } It results the encoding being wrongly set to 7-bit(0) as following: > I/Gecko ( 2976): RIL Worker: Got segment no.1 of a multipart SMS: > {"SMSC":"+14044550009","mti":0,"udhi":64,"sender":"206","recipient":null,"pid":0, > "epid":0,"dcs":245,"encoding":0,"data":null,"timestamp":1336500242000,"status":null, > "scts":null,"dt":null,"header":{"length":11,"langIndex":0,"langShiftIndex":0, > "destinationPort":2948,"originatorPort":9200,"segmentRef":200,"segmentMaxSeq":2, > "segmentSeq":1},"segmentMaxSeq":2,"receivedSegments":1,"segments":[....]} This case is reproducible at receiving an MMS notification in T-Mobile network.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → vyang
Updated•13 years ago
|
Attachment #622057 -
Flags: review?(philipp) → review+
Comment 2•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c36aa0f1c43e
Target Milestone: --- → mozilla15
Comment 3•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c36aa0f1c43e
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•