Closed Bug 75310 Opened 24 years ago Closed 16 years ago

nsSlidingSharedBufferList leaks using view source

Categories

(Core :: XPCOM, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: dbaron, Assigned: jag+mozilla)

References

Details

(Keywords: memory-leak)

DESCRIPTION: When using view-source on an HTML document under the Boehm GC (I see syntax highlighting in view-source -- I'm not sure if I needed to do something to enable that), I see massive leaks of nsSlidingSharedBufferList objects allocated on the stack: nsSlidingSubstring::Rebind(nsAString&) /builds/seamonkey/mozilla/string/src/nsSlidingString.cpp:195 CAttributeToken::SetKey(nsAString&) /builds/seamonkey/mozilla/htmlparser/src/nsHTMLTokens.cpp:1715 CViewSourceHTML::BuildModel(nsIParser*, nsITokenizer*, nsITokenObserver*, nsIContentSink*) /builds/seamonkey/mozilla/htmlparser/src/nsViewSourceHTML.cpp:520 I'm using a build from today's tree closure (with many local changes, as always).
I was saying massive because the leak log is a few meg, but the leak log probably has a few K for each 20 bytes leaked. So it probably means we're leaking an amount on the same order of magnitude as the size of the HTML document itself, which isn't really massive.
Keywords: mlk
Summary: massive nsSlidingSharedBufferList leaks using view source → nsSlidingSharedBufferList leaks using view source
Blocks: 70090
Status: NEW → ASSIGNED
Blocks: 92580
No longer blocks: 92580
giving up ancient string bugs to the new string owner. jag, you'll want to sort through these and see which ones still apply and go with or against the direction in which you intend strings evolve
Assignee: scc → jaggernaut
Status: ASSIGNED → NEW
WFM? I haven't tested with Boehm (like dbaron) or Valgrind, but trace-refcnt shows no leaks with View Source now that bug 395845 and bug 402633 are fixed.
Not sure what ever happened to this, but nsSlidingString is gone. nsScannerString (once a derived class) is still around, but I suspect there's another bug if it is leaking any objects.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
Component: String → XPCOM
You need to log in before you can comment on or make changes to this bug.