Closed
Bug 753250
Opened 13 years ago
Closed 13 years ago
Tap target for checkboxes and radio-buttons are too small
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox14 verified, firefox15 verified, blocking-fennec1.0 soft, fennec15+)
VERIFIED
FIXED
Firefox 15
People
(Reporter: aakashd, Assigned: kats)
References
()
Details
(Keywords: uiwanted, Whiteboard: [Engagement])
Attachments
(2 files)
(deleted),
patch
|
mfinkle
:
review+
mfinkle
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details |
Build Id: 5/8/2012 Aurora
Device: LG Revolution
Steps to Reproduce:
1. Go to mail.mozilla.com/zimbra
2. Login
3. Tap on any of the checkboxes for an e-mail entry
Actual Results:
It generally takes about 2-4 taps to figure out where the checkbox tap target is at. I get it right on the stockbrowser pretty easily.
Expected Results:
Should take only 1 tap to check a checkbox.
Comment 1•13 years ago
|
||
This is a general problem I find with any site that uses check-boxes and or radio buttons.
status-firefox14:
--- → affected
status-firefox15:
--- → affected
Summary: Tap target for checkboxes on mail.mozilla.com are too small → Tap target for checkboxes and radio-buttond are too small
Version: Firefox 14 → Trunk
Updated•13 years ago
|
Summary: Tap target for checkboxes and radio-buttond are too small → Tap target for checkboxes and radio-buttons are too small
Comment 2•13 years ago
|
||
Is this a Firefox problem, or a website problem?
Reporter | ||
Comment 3•13 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Is this a Firefox problem, or a website problem?
Firefox; it happens on other sites like mail.yahoo.com too.
Assignee | ||
Updated•13 years ago
|
Blocks: clicksdontwork
Comment 4•13 years ago
|
||
(In reply to Aakash Desai [:aakashd] from comment #3)
> (In reply to Mark Finkle (:mfinkle) from comment #2)
> > Is this a Firefox problem, or a website problem?
>
> Firefox; it happens on other sites like mail.yahoo.com too.
My point is: tiny checkboxes are hard to tap. Make a better mobile friendly site.
I don't think fennec is going to scale up the checkbox. We'd likely break the layout. We already try to look for clickable item "around" where you tap.
What's the thoughts on how to fix this?
Updated•13 years ago
|
tracking-fennec: --- → ?
Comment 6•13 years ago
|
||
That would have been my suggestion, to expand the tappable area to a certain distance around the object, preferably without augmenting the layout of the page.
If we're already doing that, are we expanding that area as far as we can, generally? Or is there room to make those hit areas a little larger?
Comment 7•13 years ago
|
||
IIRC, we used a "weighting" system to favor some elements higher than others. So if you tapped near a link, but a button was actually closer, we'd pick the link anyway.
(i.e. links are weighted higher)
Maybe we should tweak the weighting system.
Assignee | ||
Comment 8•13 years ago
|
||
(In reply to Aakash Desai [:aakashd] from comment #0)
> Build Id: 5/8/2012 Aurora
>
> Device: LG Revolution
>
> Steps to Reproduce:
> 1. Go to mail.mozilla.com/zimbra
> 2. Login
> 3. Tap on any of the checkboxes for an e-mail entry
>
Which view are you viewing zimbra in? When I log in I get the "Thin (EDGE/GPRS)" view and I'm able to click on the checkboxes easily enough (using latest m-c code on a Galaxy Nexus). In that view the checkboxes are actually sized larger by zimbra, to 18px. I can see what it looks like on other devices but I want to make sure I'm looking at the same thing first. Also if you have any other specific pages on which it's hard to tap checkboxes please post URLs/STRs.
Simple test page : http://people.mozilla.com/~nhirata/html_tp/formsninput.html
Updated•13 years ago
|
tracking-fennec: --- → 15+
blocking-fennec1.0: ? → soft
Assignee | ||
Comment 10•13 years ago
|
||
Excellent, thanks. That test page is made worse by font inflation, because the text is inflated but the radio buttons/checkboxes remain teeny-tiny. Even if I disable font inflation and zoom in a bit though, it's hard to click on those form elements. I'll try tweaking the weighting algorithm we're using.
Assignee | ||
Comment 11•13 years ago
|
||
The touch radius claimed to be an inch-based measurement but wasn't actually. Dividing by zoom fixes that. However in this case the real problem is just that the touch radius isn't large enough and wasn't picking up the checkboxes.
In theory this change makes sense to me but in practice it might have bad fallout. It should bake on m-c for a week or two before getting uplifted anywhere, if at all.
Attachment #626553 -
Flags: review?(wjohnston)
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → bugmail.mozilla
Comment 12•13 years ago
|
||
Comment on attachment 626553 [details] [diff] [review]
Patch
Looks good to me. I think increasing it is a good idea.
Attachment #626553 -
Flags: review?(wjohnston) → review?(mark.finkle)
Comment 13•13 years ago
|
||
Comment on attachment 626553 [details] [diff] [review]
Patch
64x64 seems OK, but I don't think we'd want to go bigger. Making it zoom dependent seems sane too.
Attachment #626553 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 14•13 years ago
|
||
Target Milestone: --- → Firefox 15
Comment 15•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 16•13 years ago
|
||
Comment on attachment 626553 [details] [diff] [review]
Patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: hard to tap small elements on the page
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): mobile-only. risk of making it harder to pick out the right link out of a bunch of links that are close together.
String or UUID changes made by this patch: none
Attachment #626553 -
Flags: approval-mozilla-aurora?
Updated•13 years ago
|
Attachment #626553 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 17•13 years ago
|
||
Comment 18•13 years ago
|
||
This is how it looks the test page. It seems that the issue still persists on Beta 14 build 4. Or is this expected? If not, should the bug be reopened?
--
Firefox 14.0b4 (2012-03-31)
Device: Samsung Galaxy Nexus
OS: Android 4.0.2
Assignee | ||
Comment 19•13 years ago
|
||
This bug doesn't change the size of the checkboxes and radio buttons - that's covered in bug 757937. This one just makes it easier to click on them even if they are tiny. To verify you should try checking/unchecking the boxes and make sure it's not too hard to do.
Comment 20•13 years ago
|
||
Verified fix on:
Nightly 15.0a1 2012-05-31/Aurora 14.0a2 2012-05-31/Firefox Native 14.0b4
Device: HTC Desire
OS: Android 2.2
Even with the issue covered by bug 757937 I am able to easily select checkboxes on the test page from Comment 9 or on gmail.com.
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•