Closed
Bug 753565
Opened 13 years ago
Closed 13 years ago
webapp.json incorrect on Mac
Categories
(Firefox Graveyard :: Web Apps, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 15
People
(Reporter: marco, Assigned: marco)
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
> let json = {
> "registryDir": this.profileFolder.path,
> "app": {
> "origin": this.launchURI.prePath,
> "installOrigin": "apps.mozillalabs.com",
> "manifest": this.manifest
> }
> };
This code shouldn't be correct.
Attachment #622537 -
Flags: review?(felipc)
|
||
Updated•13 years ago
|
Priority: -- → P3
Target Milestone: --- → Firefox 15
|
||
Comment 1•13 years ago
|
||
Comment on attachment 622537 [details] [diff] [review]
Patch
Marco, as the webapp.json file is needed on all platforms, and it is the same file on all of them, could you instead move the json object generation to a function outside of the platform-specific part, and use that in all platforms?
The writeToFile part can stay inside each part as the file path varies.
Attachment #622537 -
Flags: review?(felipc)
|
Assignee | |
Comment 2•13 years ago
|
||
Assignee: nobody → mar.castelluccio
Attachment #622537 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #625488 -
Flags: review?(felipc)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 625488 [details] [diff] [review]
Patch v2
thank you!
Attachment #625488 -
Flags: review?(felipc) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•13 years ago
|
||
Internal code change - Does not look like anything needs verification.
Whiteboard: [qa-]
|
|
||
Updated•12 years ago
|
Flags: in-moztrap-
|
|
||
Updated•12 years ago
|
QA Contact: jsmith
|
||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•