Prerequisites: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 Steps to reproduce: 1.Login to MP and go to https://marketplace.mozilla.org/en-US/search/?device=tablet&cat=159 2.Now apply some more filters from "Price" section: Any Price, Free Only and Premium Only 3.Observe the number of results for each filter applied at step 2. Expected results: Number of apps displayed for "Any Price" filter should be equal with sum of apps displayed for "Free only" and "Premium Only" Actual Results: The number of results are different. Please see the screencast for this bug: http://screencast.com/t/odDa8qy3F NOTE:Reproducible on staging too but added steps from production where the issue is more visible because we have more apps submitted.

Issue is easily reproducible using https://marketplace-dev.allizom.org/en-US/search/?q=seavan , where after applying "Free Only" filter , the "charm of the highway strip " app is missing from free apps list.

That doesn't look like it fixed it...

The reason that patch didn't fix the problem is because when we filter by premium only apps, it searches for: 1. premium_type__in=amo.ADDON_PREMIUMS and 2. price__gt=0 But the price on "charm of the highway strip" is $0.00 which isn't > 0. But the facet only picks up on the premium_type. Is it valid to be one of the PREMIUM types and have a price of zero?

I'll CC Andym for confirmation but I'm pretty sure premium and $0.00 is valid (generally to be used for temporary reductions in price or something). That's why we have the $0.00 tier at all.

It is now, so go for price__gte=0 (or remove it).

Do we need some visual indicator that this $0.00 app is a premium app? E.g. in a search a user could see an app with a green tag of $0.00 and next to it another app with a green tag of "FREE", and wonder what's up. I have a fix for this bug here: https://github.com/robhudson/zamboni/commit/0804971

(In reply to Rob Hudson [:robhudson] from comment #7) > Do we need some visual indicator that this $0.00 app is a premium app? E.g. > in a search a user could see an app with a green tag of $0.00 and next to it > another app with a green tag of "FREE", and wonder what's up. Probably, but that's something we'll get feedback on from users and guidance from U[RX] on. No need to worry for now.

Trying again: https://github.com/mozilla/zamboni/commit/8e2a53d

Reopened after comparing results from a blank search on https://marketplace-dev.allizom.org/search/ where : Any price = 88 matching results Free only = 50 matching results Premium only = 35 matching results Three apps are missing.

Verified as fixed : http://screencast.com/t/2kprCxDhKWh