Closed
Bug 753864
Opened 12 years ago
Closed 12 years ago
[traceback] TypeError on /users/edit/$id
Categories
(Marketplace Graveyard :: Admin Tools, defect, P2)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: clouserw, Unassigned)
References
Details
TypeError: SimpleSearchForm() takes exactly 1 argument (2 given)
http://sentry.dmz.phx1.mozilla.com/marketplace/group/188/
Logger: root Level: error
Server: web16.addons.phx1.mozilla.com First Seen: May 10, 2012
Stacktrace
Stacktrace (most recent call last):
File "django/core/handlers/base.py", line 111, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File "amo/decorators.py", line 128, in wrapper
return f(*args, **kw)
File "amo/decorators.py", line 120, in wrapper
return f(*args, **kw)
File "amo/decorators.py", line 29, in wrapper
return func(request, *args, **kw)
File "amo/decorators.py", line 60, in wrapper
return f(request, *args, **kw)
File "apps/users/views.py", line 259, in admin_edit
{'form': form, 'amouser': amouser})
File "jingo/__init__.py", line 80, in render
rendered = render_to_string(request, template, context)
File "jingo/__init__.py", line 98, in render_to_string
return template.render(**get_context())
File "jinja2/environment.py", line 891, in render
return self.environment.handle_exception(exc_info, True)
File "/data/www/addons.mozilla.org/zamboni/apps/users/templates/users/edit.html", line 3, in top-level template code
{% from 'devhub/includes/macros.html' import some_html_tip %}
File "/data/www/addons.mozilla.org/zamboni/templates/impala/base_shared.html", line 4, in top-level template code
{% extends 'impala/base.html' %}
File "/data/www/addons.mozilla.org/zamboni/templates/impala/base.html", line 58, in top-level template code
{% block site_header %}
File "/data/www/addons.mozilla.org/zamboni/templates/impala/base.html", line 86, in block "site_header"
{% block search_form %}
File "/data/www/addons.mozilla.org/zamboni/templates/impala/base.html", line 89, in block "search_form"
{% include 'impala/search.html' %}
File "/data/www/addons.mozilla.org/zamboni/templates/impala/search.html", line 5, in top-level template code
{% set search_form = SimpleSearchForm(request, search_cat) %}
Http
URL: https://marketplace.mozilla.org/en-US/users/edit/10482
Method: GET
Query: ''
Updated•12 years ago
|
Target Milestone: --- → 2012-05-17
Reporter | ||
Updated•12 years ago
|
Target Milestone: 2012-05-17 → ---
Comment 1•12 years ago
|
||
What's going on here is we're loading a user edit template from AMO. That template loads a helper called `SimpleSearchForm`, but since we're in marketplace that helper is defined and loaded from the mkt code which has it defined with different arguments. So this 500's.
I looked at the sentry report and this came from the admin.
I think the fix is to load marketplace's account settings page rather than AMO's user edit page. The equivalent of that page for this user is:
https://marketplace-dev.allizom.org/en-US/users/10482/edit
To do that would require editing the URL that's loaded in the admin user search here to redirect to the right place depending on whether we are AMO or MKT:
https://marketplace-dev.allizom.org/en-US/admin/
Updated•12 years ago
|
Assignee: nobody → robhudson.mozbugs
Comment 2•12 years ago
|
||
I'm going to let this one go. It's actually the javascript that is appending the user ID to the URL and routing to AMO's style of URL:
https://github.com/mozilla/zamboni/blob/master/media/js/zamboni/admin.js#L28
The URL difference is:
AMO: /users/edit/10482
MKT: /users/10482/edit
Assignee: robhudson.mozbugs → nobody
Reporter | ||
Comment 3•12 years ago
|
||
Thanks rob. I'm going to wontfix this since the links on the page link to the marketplace style URL.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•