Closed
Bug 754035
Opened 12 years ago
Closed 12 years ago
Implement the Australis tabs on OS X
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
(Whiteboard: Fixed by Bug 763308)
Attachments
(2 files, 3 obsolete files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
andreasn
:
ui-review+
bwinton
:
feedback+
|
Details | Diff | Splinter Review |
The same as bug 743629 but for OS X
Assignee | ||
Comment 1•12 years ago
|
||
This patch is a adaption of the Aero implementation.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #622911 -
Flags: ui-review?(nisses.mail)
Attachment #622911 -
Flags: review?(nisses.mail)
Comment 2•12 years ago
|
||
As https://people.mozilla.com/~shorlander/files/australis-designSpecs/ gives a error 500 right now, I'm going to wait until tomorrow before I finish the review, in case there is some spacing I don't remember about.
In the mean time, there is some odd resizing going on if you open more than 5 tabs, but apart from that it looks all good.
Comment 3•12 years ago
|
||
Comment on attachment 622911 [details] [diff] [review]
patch for OS X
marking review-minus due to several small issues we found on IRC.
Attachment #622911 -
Flags: ui-review?(nisses.mail)
Attachment #622911 -
Flags: ui-review-
Attachment #622911 -
Flags: review?(nisses.mail)
Attachment #622911 -
Flags: review+
Assignee | ||
Comment 4•12 years ago
|
||
Next try
Fixed the gap in overflow mode (gap).
Better centered tab separator.
Last tab separator hidden in overflow mode.
Spacing should be correct between tab icon and text.
Attachment #622911 -
Attachment is obsolete: true
Attachment #624348 -
Flags: ui-review?(nisses.mail)
Attachment #624348 -
Flags: review?(nisses.mail)
Comment 5•12 years ago
|
||
Comment on attachment 624348 [details] [diff] [review]
patch for OS X v2
Every second tab still looks fuzzy when selected if there are lots of tabs open, and there is also a 1px gap in the same tabs upon hover.
Attachment #624348 -
Flags: ui-review?(nisses.mail) → ui-review-
Assignee | ||
Comment 6•12 years ago
|
||
New approach and I'm careful. I'm only asking for feedback first. ;)
I've done the tab graphics now with full images instead of gradients. This should work better.
I've also added the hover area directly over the painted tabs. If you're outside of the curves the tabs don't react.
I'm using now the FX arrow for the overflow arrow buttons.
Attachment #624348 -
Attachment is obsolete: true
Attachment #624348 -
Flags: review?(nisses.mail)
Attachment #625403 -
Flags: feedback?(nisses.mail)
Attachment #625403 -
Flags: feedback?(bwinton)
Comment 7•12 years ago
|
||
Comment on attachment 625403 [details] [diff] [review]
patch for OS X v3
Gets rid of the fuzzyness when using lots of tabs!
There is a small 1px darker pixel (we talked about this on irc I think) that appears on the right side of the tab just before the bevel starts, and using personas this shows as a 1px gap.
Attachment #625403 -
Flags: feedback?(nisses.mail) → feedback+
Comment 8•12 years ago
|
||
Comment on attachment 625403 [details] [diff] [review]
patch for OS X v3
The click area is _slightly_ odd on the bottom right of a non-active tab.
(It seems like the dividing line isn't the vertical line when we're not hovering, but is instead a couple of pixels to the left of that line.)
Other than that, and the stuff Andreas mentioned, I like it. f=me.
Attachment #625403 -
Flags: feedback?(bwinton) → feedback+
Assignee | ||
Comment 9•12 years ago
|
||
This patch is based now on the FX implementation and with the FX tab structure.
Because of the structure change we can't land this patch only for OSX. To land I need to do a patch for all four platforms.
I'll do in separate bugs the ui-r and then in one the whole patch for check-in. Is this okay?
Attachment #625403 -
Attachment is obsolete: true
Attachment #631106 -
Flags: ui-review?(nisses.mail)
Attachment #631106 -
Flags: feedback?(bwinton)
Comment 10•12 years ago
|
||
Comment on attachment 631106 [details] [diff] [review]
patch for OS X v4
Tested with regular theme and both light and dark personas. Works most excellent!
Attachment #631106 -
Flags: ui-review?(nisses.mail) → ui-review+
Comment 11•12 years ago
|
||
Comment on attachment 631106 [details] [diff] [review]
patch for OS X v4
Sweet! f=me!
Attachment #631106 -
Flags: feedback?(bwinton) → feedback+
Assignee | ||
Comment 12•12 years ago
|
||
Fixed by Bug 763308
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: Fixed by Bug 763308
You need to log in
before you can comment on or make changes to this bug.
Description
•