Closed
Bug 754801
Opened 13 years ago
Closed 13 years ago
browser_aboutCrashes.js leaks one about:blank window
Categories
(Toolkit :: Crash Reporting, defect)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
DUPLICATE
of bug 734172
People
(Reporter: dao, Unassigned)
References
Details
(Keywords: memory-leak)
This shows in debug build test logs:
[toolkit/crashreporter/test/browser/browser_aboutCrashes.js]
1 window(s) [url = about:blank]
Comment 1•13 years ago
|
||
I don't know enough about how chrome leaks happen, but the test adds an about:blank tab:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/test/browser/browser_aboutCrashes.js#24
and loads about:crashes in it:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/test/browser/browser_aboutCrashes.js#31
then removes the tab after the page loads and it checks the contents:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/test/browser/browser_aboutCrashes.js#9
There aren't any global variables or expando properties holding on to anything. Does the test need to explicitly clean something else up?
Reporter | ||
Comment 2•13 years ago
|
||
I don't see anything wrong in the test, but maybe there's a problem with head.js. Common pitfalls are stale event listeners or observers. Or maybe this is not at all a testing issue but a bug in the code being tested.
Comment 3•13 years ago
|
||
The most complicated thing that head.js does is register a directory service provider to override the UAppData directory:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/test/browser/head.js#11
it does unregister it at cleanup, but I don't see how that'd leak a window in any case.
The code being tested is a pretty simple xhtml about page:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/content/crashes.xhtml
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/content/crashes.js
Reporter | ||
Comment 4•13 years ago
|
||
(In reply to Ted Mielczarek [:ted] from comment #3)
> The code being tested is a pretty simple xhtml about page:
> http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/content/
> crashes.xhtml
> http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/content/
> crashes.js
Well, there's more code than what's directly in those files. For instance, I see crashes.js call CrashSubmit.submit with callbacks that CrashSubmit stores in _activeSubmissions.
Comment 5•13 years ago
|
||
That's true, but for this particular test (browser_aboutCrashes.js), none of that code is called. It simply loads about:crashes, verifies the contents (which are built as the page loads by scanning some local directories), and then closes the tab.
Reporter | ||
Comment 6•13 years ago
|
||
Another possibility is that this the fault of browser_save_resend_postdata.js, which is known to leak and runs right before this test.
Depends on: 734172
Reporter | ||
Updated•13 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•