Closed Bug 755122 Opened 12 years ago Closed 12 years ago

remove bufferToArrayHack from frameworker

Categories

(Firefox Graveyard :: SocialAPI, defect)

Product:
Firefox Graveyard
Component:
SocialAPI
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(firefox17 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 18
Tracking Flags:
Tracking Status
firefox17 --- fixed

People

(Reporter: mixedpuppy, Assigned: markh)

References

Details

(Whiteboard: [Fx17][qa-])

Attachments

(1 file)

remove the hack
(deleted), patch
markh
: review+
Gavin
: approval-mozilla-aurora+
Details | Diff | Splinter Review
moved from https://github.com/mozilla/socialapi-dev/issues/24 There are js compartment issues with Uint8Array, related to bug 734215.
Depends on: 741041
We still have a problem, now getting "permission denied to access object".
Blocks: 762569
Whiteboard: [ms2]
Whiteboard: [ms2] → [Fx17]
This should have been fixed by bug 734215 - need to re-test.
Assignee: nobody → mhammond
My testing shows this as now working correctly - but I'm leaving this open as a reminder to remove the bufferToArrayHack from frameworker (or at least create a strategy to remove it - immediate removal might break amigo in the short term)
Is the relevant functionality not covered by the landed tests? testArrayUsingBuffer seems to cover it.
Attached patch remove the hack (deleted) — — Splinter Review
Attachment #638781 - Flags: review?(mhammond)
Comment on attachment 638781 [details] [diff] [review] remove the hack Yeah, testArrayUsingReader should cover it, so I guess a trivial s/todo// in browser_frameworker is also needed (I'm still getting a FF crash running that test from the addon, so I'm struggling to confirm it via the tests)
Attachment #638781 - Flags: review?(mhammond) → review+
Hardware: x86 → All
Summary: ArrayBuffer/Uint8Array stuff not working in nightly → remove bufferToArrayHack from frameworker
this hack function has not been in use for a few weeks, we can remove it.
https://hg.mozilla.org/mozilla-central/rev/3f7c590243c7
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Attachment #638781 - Flags: approval-mozilla-aurora+
Does this have or need an automated testcase?
Flags: in-testsuite?
No, this is just code removal.
Flags: in-testsuite? → in-testsuite-
Whiteboard: [Fx17] → [Fx17][qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: