Marc Attinasi Reporter
	Description • 24 years ago

When some piece of content has a state change we currently resolve all style for
that element and all of its children. This is terribly inefficient, and causes
incredible performance problems when rules like '*:active' are present because
any state change ends up re applying ALL rules on potentially all elements (if
the BODY or root element is the one who's state is changing). A smarter approach
would be to simply re-apply the style rules that have dynamic pseudos in them,
as these are the only ones that can change when a content state change happens.
Even better would be to restrict it to rules that have a specific dynamic
pseudo, like the :active when a content state change for 'active' happens, or
:hover when a content state for hover happens.

The hack put in for bug 58821 can then be removed, allowing a wider application
of the dynamic pseudos without suffering from abysmal performance.

	James Green
	Comment 1 • 24 years ago

CC self, perf keyword and nominating for 0.9.1, 1.0, since we wouldn't want to
forget about this for too long :)

	Hixie (not reading bugmail)
	Comment 2 • 24 years ago

cc'ing hyatt since :active, :hover and :focus (and later :disabled, :enabled,
:checked, :selected, and what not) are things that I believe interest him. ;-)

	Marc Attinasi Reporter
	Comment 3 • 24 years ago

Adding the URL from the old bug - Ian, please don't remove that page!

Also, setting milestone to Moz 1.0 for now - far too many 0.9.1 bugs on my lap
already, and this one does not crash or hang or corrupt data ;)

	Marc Attinasi Reporter
	Comment 4 • 23 years ago

I wonder if this was fixed with the RuleTree landing...

	Kevin McCluskey (gone)
	Comment 5 • 23 years ago

Reassigning to Pierre

	Markus Hübner
	Comment 6 • 23 years ago

Wouldn't this be a perfect 1.0 candidate?

	Kevin McCluskey (gone)
	Comment 7 • 23 years ago

Bulk moving Mozilla1.01 bugs to future-P1

	Boris Zbarsky [:bzbarsky]
	Comment 8 • 23 years ago

*** Bug 132598 has been marked as a duplicate of this bug. ***

	David Baron :dbaron: Assignee
	Comment 9 • 23 years ago

My patch in bug 5693 has some optimizations -- it makes HasStateDependentStyle
state-specific.

Bug 96984 is about removing the hack.

	David Baron :dbaron: Assignee
	Comment 10 • 23 years ago

See also bug 137395, which is a bug that we should try to fix when we consider a
better way to optimize this.

	Madhur Bhatia
	Comment 11 • 22 years ago

cc'ing myself

	David Baron :dbaron: Assignee
	Comment 12 • 22 years ago

Assigning pierre's remaining Style System-related bugs to myself.

	Boris Zbarsky [:bzbarsky]
	Comment 13 • 21 years ago

So now that we have HasStateDependentStyle, is this still an issue?

	David Baron :dbaron: Assignee
	Comment 14 • 21 years ago

No.