Closed Bug 755828 Opened 13 years ago Closed 13 years ago

pymake should copy gmake behavior of not rebuilding targets with no commands, even if they're out of date

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: khuey, Assigned: khuey)

References

Details

Attachments

(1 file)

Patch
(deleted), patch
ted
: review+
Details | Diff | Splinter Review 
Given:

all: obj

obj: header
	touch obj

header: cpp

cpp:
	touch header
	touch cpp

On the second pass pymake will decide that header is out of date, and rebuild it.  It will then rebuild obj because header was rebuilt, even though header did not change.  Gmake will decide that rebuilding header serves no purpose since it has no rule, and skip it.  It will then not rebuild obj.
Attached patch Patch (deleted) — — Splinter Review 

  

  



        Attachment #624466 -
        Flags: review?(ted.mielczarek)

        Attachment #624466 -
        Flags: review?(ted.mielczarek) → review+

    
    

    
  
http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/7b1a8cd06963

  

  


Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

    
    

    
  
https://hg.mozilla.org/projects/build-system/rev/e5e7f60fe0be

  

  


Target Milestone: --- → mozilla15

    
    

    
  
And migrated to m-c https://hg.mozilla.org/mozilla-central/rev/e5e7f60fe0be

  

  



    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: