Closed
Bug 756298
Opened 13 years ago
Closed 13 years ago
channel-prefs.js cannot be located in the applications 'pref' directory
Categories
(Mozilla QA Graveyard :: Mozmill Automation, defect)
Mozilla QA Graveyard
Mozmill Automation
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: davehunt, Assigned: davehunt)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
davehunt
:
review+
|
Details | Diff | Splinter Review |
With bug 746156 the channel-prefs.js for freshly downloaded copies of Firefox is now located in 'preferences' folder rather than 'pref'. We should update libs/application.py with this new location.
Updated•13 years ago
|
Blocks: 746156
Keywords: regression
Assignee | ||
Comment 1•13 years ago
|
||
This now returns either the 'preferences' or 'pref' folder (in that order) depending on where the file is found. If it's not found a suitable exception is thrown.
Comment 2•13 years ago
|
||
Comment on attachment 624955 [details] [diff] [review]
Look for channel-prefs.js file in multiple locations. v1.0
>+ if os.path.exists(pref_path):
>+ return pref_path
>+ raise Exception("Channel preferences path not found.")
Please make use of the errors.NotFoundException class here.
With that fixed r=me. Once updated please land it right away and if possible trigger a testrun for the latest nightly builds.
Attachment #624955 -
Flags: review?(hskupin) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #624955 -
Attachment is obsolete: true
Attachment #624959 -
Flags: review+
Assignee | ||
Comment 4•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•