Closed
Bug 757177
Opened 13 years ago
Closed 13 years ago
4 unused variable warnings in new file SVGFragmentIdentifier.cpp
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
Bug 512525 added the new file SVGFragmentIdentifier.cpp with some unused variables in it:
{
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp: In static member function 'static bool mozilla::SVGFragmentIdentifier::ProcessSVGViewSpec(const nsAString_internal&, nsSVGSVGElement*)':
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:151:27: warning: unused variable 'oldViewBoxPtr' [-Wunused-variable]
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:159:33: warning: unused variable 'oldPARPtr' [-Wunused-variable]
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:167:19: warning: unused variable 'oldZoomAndPanPtr' [-Wunused-variable]
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp: At global scope:
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:14:25: warning: 'sZoomAndPanMap' defined but not used [-Wunused-variable]
}
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Assignee | ||
Updated•13 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Assignee | ||
Comment 1•13 years ago
|
||
Looks like all of these variables were just left over from an older patch-version, and they now have versions of themselves that live elsewhere (which are actually used).
The only "sZoomAndPanMap" that we use lives on nsSVGSVGElement (so the local one can go away), and the "oldXXX" variables now live in their various "SaveOldXXX" functions (so they can go away too).
Attachment #625737 -
Flags: review?(longsonr)
Updated•13 years ago
|
Attachment #625737 -
Flags: review?(longsonr) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Target Milestone: --- → mozilla15
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•