We should restore the latest size and preset.

rebased

Comment on attachment 627753 [details] [diff] [review] patch v1 Review of attachment 627753 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/responsivedesign/responsivedesign.jsm @@ +76,5 @@ > this.presets = [{custom: true}]; > } > > // Default size. The first preset (custom) is the one that will be used. > let bbox = this.stack.getBoundingClientRect(); Do you need this bbox @@ +81,5 @@ > + > + try { > + this.presets[0].width = Services.prefs.getIntPref("devtools.responsiveUI.customWidth"); > + this.presets[0].height = Services.prefs.getIntPref("devtools.responsiveUI.customHeight"); > + this.currentPreset = Services.prefs.getIntPref("devtools.responsiveUI.currentPreset"); Should there be a sanity check on these values? Can a really-large custom size cause any real problems? Should the preset be some sort of absolute string rather than an integer index? That could make later updates to the preset list less fragile. @@ +306,5 @@ > */ > rotate: function RUI_rotate() { > this.setSize(this.currentHeight, this.currentWidth); > + if (this.currentPreset == 0) > + this.saveCustomSize(); Do you save the rotation value anywhere?

(In reply to Dave Camp (:dcamp) from comment #3) > Comment on attachment 627753 [details] [diff] [review] > patch v1 > > Review of attachment 627753 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: browser/devtools/responsivedesign/responsivedesign.jsm > @@ +76,5 @@ > > this.presets = [{custom: true}]; > > } > > > > // Default size. The first preset (custom) is the one that will be used. > > let bbox = this.stack.getBoundingClientRect(); > > Do you need this bbox ... outside of the catch block?

addressed dave's comments

I had bitrotted you pretty badly, so I fixed it.