Closed
Bug 757483
Opened 13 years ago
Closed 13 years ago
Score Rush gets more choppy w/ igc
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: luke, Assigned: billm)
References
(Blocks 1 open bug)
Details
(Whiteboard: [js:p2][games])
Attachments
(3 files)
With bug 750834 Score Rush is pretty smooth (17ms to render a frame). The GC pauses are 35ms which is also pretty ok. However, if you turn on igc, things are observably worse.
The per-frame profile attached also looks a lot worse: lots of recompilation, lots of interpreter time. It almost looks like there is a bug involving igc where we throw away/recompile too much.
(To view the profile, you'll need to use billm's viewer.)
|
Reporter | |
Comment 1•13 years ago
|
||
This is w/ igc turned off. Looks much prettier.
|
Assignee | |
Updated•13 years ago
|
Attachment #626050 -
Attachment mime type: text/plain → application/octet-stream
|
||
Updated•13 years ago
|
Blocks: IncrementalGC
|
|
Reporter | |
Updated•13 years ago
|
Attachment #626052 -
Attachment mime type: text/plain → application/octet-stream
|
|
||
Updated•13 years ago
|
Whiteboard: games → [js:p2][games]
|
|
Assignee | |
Updated•13 years ago
|
Assignee: general → wmccloskey
|
|
Assignee | |
Comment 2•13 years ago
|
||
We were setting the preserve flag in BeginMarkPhase, which is called once per incremental GC, and then unsetting it in ~AutoGCSession, which is called at the end of every slice. So in later slices, code was getting thrown away.
Attachment #626537 -
Flags: review?(bhackett1024)
|
||
Updated•13 years ago
|
Attachment #626537 -
Flags: review?(bhackett1024) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Target Milestone: --- → mozilla15
|
|
Reporter | |
Comment 4•13 years ago
|
||
Wow, that was fast! With this patch, I can see the biggest GC slice (the first) is only 16.6ms and the whole frame renders in 28.4ms; big improvement over non-incremental.
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•