Closed
Bug 757512
Opened 13 years ago
Closed 13 years ago
B2G RIL: SIM Card Lock DOM Requests don't properly clean up
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: marshall, Assigned: allstars.chh)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
philikon
:
review+
|
Details | Diff | Splinter Review |
The DOMRequests used to provide callbacks for the nsIDOMMobleConnection.getCardLock/setCardLock/unlockCardLock are not currently cleaning up the allocated DOM requests when status is sent back in ril_worker.js.
The two examples I found were in dom/system/gonk/RILContentHelper.js (lines 317/325ish), where the use of this.getRequest(requestId) could be simply changed to this.takeRequest(requestId)
|
||
Updated•13 years ago
|
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #626310 -
Flags: review?(philipp)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 626310 [details] [diff] [review]
Patch
Thanks for Marshall to point this out.
|
|
||
Updated•13 years ago
|
Attachment #626310 -
Flags: review?(philipp) → review+
|
|
||
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•