Closed
Bug 757642
Opened 13 years ago
Closed 5 years ago
WebGL antialiasing: un-blacklist "ATI Technologies Inc. -- ATI Radeon HD 6770M OpenGL Engine -- 2.1 ATI-7.18.18"
Categories
(Core :: Graphics: CanvasWebGL, defect, P1)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla69
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: jgilbert)
References
(Blocks 1 open bug)
Details
(Whiteboard: webgl-driver)
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
I set the webgl.msaa-force to true, and ran a bunch of WebGL pages, with no apparent problems. The renderings were correctly anti-aliased.
My about:support gfx section:
Graphics
Vendor ID0x1002Device ID0x6740WebGL RendererATI Technologies Inc. -- ATI Radeon HD 6770M OpenGL Engine -- 2.1 ATI-7.18.18GPU Accelerated Windows4/4 OpenGL
AzureBackendquartz
Reporter | ||
Updated•13 years ago
|
Summary: Please un-blacklist → Please un-blacklist "ATI Technologies Inc. -- ATI Radeon HD 6770M OpenGL Engine -- 2.1 ATI-7.18.18"
Reporter | ||
Updated•13 years ago
|
Blocks: gecko-games
Updated•13 years ago
|
Summary: Please un-blacklist "ATI Technologies Inc. -- ATI Radeon HD 6770M OpenGL Engine -- 2.1 ATI-7.18.18" → WebGL antialiasing: un-blacklist "ATI Technologies Inc. -- ATI Radeon HD 6770M OpenGL Engine -- 2.1 ATI-7.18.18"
Comment 1•13 years ago
|
||
I forgot to ask: what's your OSX version?
Reporter | ||
Comment 2•13 years ago
|
||
10.7.4.
Assignee | ||
Comment 3•12 years ago
|
||
Please run the 1.0.1 conformance tests and detail which failures are found:
https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/conformance-suites/1.0.1/webgl-conformance-tests.html
Updated•12 years ago
|
No longer blocks: gecko-games
Comment 4•12 years ago
|
||
I also have a Macbook Pro with the 6770M running 10.7.4. Here's the conformance test failures with today's nightly:
WebGL Conformance Test Results
Version 1.0.1
-------------------
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/16.0 Firefox/16.0
WebGL VENDOR: Mozilla
WebGL VERSION: WebGL 1.0
WebGL RENDERER: Mozilla
Unmasked VENDOR: undefined
Unmasked RENDERER: undefined
WebGL R/G/B/A/Depth/Stencil bits (default config): 8/8/8/8/32/0
-------------------
Test Summary (8881 total tests):
Tests PASSED: 8766
Tests FAILED: 115
Tests TIMED OUT: 0
-------------------
Failures:
conformance/attribs/gl-vertexattribpointer-offsets.html: 60 tests failed
conformance/glsl/functions/glsl-function-distance.html: 2 tests failed
conformance/glsl/functions/glsl-function-dot.html: 2 tests failed
conformance/glsl/functions/glsl-function-length.html: 2 tests failed
conformance/glsl/variables/gl-pointcoord.html: 48 tests failed
conformance/programs/program-test.html: 1 tests failed
Comment 5•12 years ago
|
||
Here's the conformance tests run with this patch:
WebGL Conformance Test Results
Version 1.0.1
-------------------
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/16.0 Firefox/16.0
WebGL VENDOR: Mozilla
WebGL VERSION: WebGL 1.0
WebGL RENDERER: Mozilla
Unmasked VENDOR: undefined
Unmasked RENDERER: undefined
WebGL R/G/B/A/Depth/Stencil bits (default config): 8/8/8/8/32/0
-------------------
Test Summary (8881 total tests):
Tests PASSED: 8766
Tests FAILED: 115
Tests TIMED OUT: 0
-------------------
Failures:
conformance/attribs/gl-vertexattribpointer-offsets.html: 60 tests failed
conformance/glsl/functions/glsl-function-distance.html: 2 tests failed
conformance/glsl/functions/glsl-function-dot.html: 2 tests failed
conformance/glsl/functions/glsl-function-length.html: 2 tests failed
conformance/glsl/variables/gl-pointcoord.html: 48 tests failed
conformance/programs/program-test.html: 1 tests failed
Assignee | ||
Comment 6•12 years ago
|
||
Sounds good, but we need to dig up the reason this was blocked to begin with, and check that this driver is unaffected by the original issue.
Comment 7•12 years ago
|
||
(In reply to Jeff Gilbert [:jgilbert] from comment #6)
> Sounds good, but we need to dig up the reason this was blocked to begin
> with, and check that this driver is unaffected by the original issue.
I believe Chrome had a big block list because they did limited testing and wanted to play it safe. We followed suit. It seems they have since relaxed it.
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #7)
> (In reply to Jeff Gilbert [:jgilbert] from comment #6)
> > Sounds good, but we need to dig up the reason this was blocked to begin
> > with, and check that this driver is unaffected by the original issue.
>
> I believe Chrome had a big block list because they did limited testing and
> wanted to play it safe. We followed suit. It seems they have since relaxed
> it.
That was largely for the driver dates, iirc. I believe the issues we were having with ATI+Mac+AA were texture corruption issues.
Comment 9•12 years ago
|
||
Here's the commit where chrome added the entries we currently have.
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/software_rendering_list.json?r1=80636&r2=87329&pathrev=87329
Here's the commit where they changed it:
http://src.chromium.org/viewvc/chrome/trunk/deps/gpu/software_rendering_list/software_rendering_list.json?r1=110204&r2=110790
Assignee | ||
Comment 10•12 years ago
|
||
Interesting. So they switched from selectively blocking cards to just blocking ATI on OSX < 10.7.2.
We should at least allow ATI cards on versions newer than that. We should consider matching their criteria and blocklisting all ATI on older OSX.
Assignee | ||
Comment 11•12 years ago
|
||
Comment on attachment 637622 [details] [diff] [review]
Patch v1
Review of attachment 637622 [details] [diff] [review]:
-----------------------------------------------------------------
We need to unblock OSX >=10.7.2 and ATI, not add a universal exception for this card. That is, unless we can dig up the testcases for the MSAA bugs, and this card passes. bjacob might better remember where these are.
Attachment #637622 -
Flags: review?(jgilbert) → review-
Updated•12 years ago
|
Assignee: jon → nobody
Status: ASSIGNED → NEW
Assignee | ||
Updated•11 years ago
|
Whiteboard: webgl-driver
Assignee | ||
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → jgilbert
Priority: P3 → P1
Assignee | ||
Comment 13•5 years ago
|
||
Previously we were hardcoding to disable on AMD. Modern MacOS versions
don't have MSAA corruption, and anything we find that does should go on
the downloadable blocklist instead.
Assignee | ||
Updated•5 years ago
|
Attachment #637622 -
Attachment is obsolete: true
Assignee | ||
Comment 14•5 years ago
|
||
We will want this to be verified on various Mac+AMD hardware after landing.
STR is: https://www.khronos.org/registry/webgl/sdk/tests/conformance/rendering/multisample-corruption.html?webglVersion=1&quiet=0&quick=1
Comment 15•5 years ago
|
||
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb974fbba61b
Rely on downloadable blocklist for Mac MSAA disabling. r=jrmuizel
Comment 16•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in
before you can comment on or make changes to this bug.
Description
•