Closed
Bug 758172
Opened 13 years ago
Closed 12 years ago
Debugger mochitests should always run with protocol logging enabled
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: past, Assigned: past)
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Bug 749231 did the same for xpcshell tests, and it can be very useful for diagnosing test failures.
Assignee | ||
Comment 1•12 years ago
|
||
How come I had never heard about build/automation.py.in until now?
Comment 2•12 years ago
|
||
(In reply to Panos Astithas [:past] from comment #1)
> Created attachment 667471 [details] [diff] [review]
> Patch v1
>
> How come I had never heard about build/automation.py.in until now?
we try to keep it secret and you just ruined it. Now we have to put all that into a new file somewhere else.
Comment 3•12 years ago
|
||
Comment on attachment 667471 [details] [diff] [review]
Patch v1
before I r+ this, have you run it through try? It has the potential to really pollute our tests. We've also had tests behave differently when debugger logging has been enabled.
I'm inclined to recommend using this for try builds only when trying to diagnose a specific problem.
Assignee | ||
Comment 4•12 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=f881e87cb260
Limiting logging to try pushes would probably be enough. How can I do this? I don't see anything in this file that differentiates between try and other builders.
Comment 5•12 years ago
|
||
unfortunately, I think that'd be a manual operation. Applying this patch to the top of your queue on a try run. :/
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> unfortunately, I think that'd be a manual operation. Applying this patch to
> the top of your queue on a try run. :/
Ah, I've been doing that already, but by modifying the default value in firefox.js instead of this.
Would you prefer to WONTFIX this bug? It has been very useful having xpcshell tests always run with logging enabled, and we have logging enabled when we write tests, so it would seem that running tests with logging enabled would be more accurate in that sense. On the other hand the xpcshell harness does not print protocol log data unless the test fails, which is not the case for mochitests.
Comment 7•12 years ago
|
||
yeah, let's wontfix this for now. We can revisit if we need to make a determined effort for test debugging.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Comment 8•12 years ago
|
||
Comment on attachment 667471 [details] [diff] [review]
Patch v1
canceling review
Attachment #667471 -
Flags: review?(rcampbell)
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•