Closed Bug 758201 Opened 13 years ago Closed 13 years ago

use PlacesUtils for LMANNO constants

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15
Tracking Status
firefox12 --- unaffected
firefox13 --- affected
firefox14 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: dataloss)

Attachments

(1 file)

From https://bugzilla.mozilla.org/show_bug.cgi?id=613588#c117 Just for coherence, should switch these to PlacesUtils
Blocks: livemarksIO
Attached patch patch v1.0 (deleted) — Splinter Review
Attachment #626804 - Flags: review?(mano)
(In reply to Marco Bonardo from comment #0) > Just for coherence, should switch these to PlacesUtils coherence? It's actually a bug, since "this" is the global object in those nested functions, and those constants don't exist there, of course.
Attachment #626804 - Flags: review?(mano) → review+
(In reply to neil@parkwaycc.co.uk from comment #2) > coherence? It's actually a bug, since "this" is the global object in those > nested functions, and those constants don't exist there, of course. ugh, sorry, missed the context. Will be better to backport the fix to Aurora.
Comment on attachment 626804 [details] [diff] [review] patch v1.0 [Approval Request Comment] Bug caused by (feature/regressing bug #): Bug 613588 User impact if declined: There is potential disruption in bookmarks json backups, drag&drop, copy&paste of livemark items Testing completed (on m-c, etc.): landing on m-c Risk to taking this patch (and alternatives if risky): just changing some "this" to the proper object, pretty safe String or UUID changes made by this patch: none
Attachment #626804 - Flags: approval-mozilla-beta?
Attachment #626804 - Flags: approval-mozilla-aurora?
Comment on attachment 626804 [details] [diff] [review] patch v1.0 [Triage Comment] This hasn't been a significant user pain point, as dupes/feedback haven't been piling up, so this doesn't meet our criteria for landing after the final beta. Approving for Aurora 14, however.
Attachment #626804 - Flags: approval-mozilla-beta?
Attachment #626804 - Flags: approval-mozilla-beta-
Attachment #626804 - Flags: approval-mozilla-aurora?
Attachment #626804 - Flags: approval-mozilla-aurora+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: