Closed
Bug 758201
Opened 13 years ago
Closed 13 years ago
use PlacesUtils for LMANNO constants
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla15
Tracking | Status | |
---|---|---|
firefox12 | --- | unaffected |
firefox13 | --- | affected |
firefox14 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: dataloss)
Attachments
(1 file)
(deleted),
patch
|
asaf
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta-
|
Details | Diff | Splinter Review |
From https://bugzilla.mozilla.org/show_bug.cgi?id=613588#c117
Just for coherence, should switch these to PlacesUtils
Assignee | ||
Updated•13 years ago
|
Blocks: livemarksIO
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #626804 -
Flags: review?(mano)
Comment 2•13 years ago
|
||
(In reply to Marco Bonardo from comment #0)
> Just for coherence, should switch these to PlacesUtils
coherence? It's actually a bug, since "this" is the global object in those nested functions, and those constants don't exist there, of course.
Updated•13 years ago
|
Attachment #626804 -
Flags: review?(mano) → review+
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to neil@parkwaycc.co.uk from comment #2)
> coherence? It's actually a bug, since "this" is the global object in those
> nested functions, and those constants don't exist there, of course.
ugh, sorry, missed the context. Will be better to backport the fix to Aurora.
Assignee | ||
Comment 4•13 years ago
|
||
Target Milestone: --- → mozilla15
Assignee | ||
Comment 5•13 years ago
|
||
Comment on attachment 626804 [details] [diff] [review]
patch v1.0
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 613588
User impact if declined: There is potential disruption in bookmarks json backups, drag&drop, copy&paste of livemark items
Testing completed (on m-c, etc.): landing on m-c
Risk to taking this patch (and alternatives if risky): just changing some "this" to the proper object, pretty safe
String or UUID changes made by this patch: none
Attachment #626804 -
Flags: approval-mozilla-beta?
Attachment #626804 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•13 years ago
|
status-firefox12:
--- → unaffected
status-firefox13:
--- → affected
status-firefox14:
--- → affected
Comment 6•13 years ago
|
||
Comment on attachment 626804 [details] [diff] [review]
patch v1.0
[Triage Comment]
This hasn't been a significant user pain point, as dupes/feedback haven't been piling up, so this doesn't meet our criteria for landing after the final beta.
Approving for Aurora 14, however.
Attachment #626804 -
Flags: approval-mozilla-beta?
Attachment #626804 -
Flags: approval-mozilla-beta-
Attachment #626804 -
Flags: approval-mozilla-aurora?
Attachment #626804 -
Flags: approval-mozilla-aurora+
Comment 8•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•