Closed
Bug 758268
Opened 12 years ago
Closed 12 years ago
IonMonkey: Rename forbidOsr and use it when calling functions directly
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
I noticed this a few days ago on some crypto benchmark. The following script will bailout every time we call f:
function f(x) {
return x >>> 0;
}
for (var i=0; i<200; i++) {
f(Math.pow(2, 31));
}
Eventually, we should fix this by adding a double/OOL path or something for >>>. However, in the meantime we should give up after bailing out a few times (and there are no type changes). We do this already when we enter via OSR, but we should also do this for non-OSR code.
|
Assignee | |
Comment 1•12 years ago
|
||
Renames forbidOsr to bailoutExpected (better name welcome), and use it also for non-OSR code.
Attachment #627934 -
Flags: review?(dvander)
|
||
Updated•12 years ago
|
Attachment #627934 -
Flags: review?(dvander) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•