Closed
Bug 758304
Opened 12 years ago
Closed 12 years ago
[Mac] crash in nsAccUtils::IsTextInterfaceSupportCorrect()
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: hub, Assigned: hub)
References
Details
(Keywords: crash)
Attachments
(1 file)
|
(deleted),
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
This crash occur since changeset 9b7bea577a43 for bug 750191. It is caused by the use of a deleted nsAccessible*, and only occur in DEBUG.
Patch coming.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Attachment #626895 -
Flags: review?(trev.saunders)
|
|
Assignee | |
Comment 2•12 years ago
|
||
setting block as it is triggered by testing bug 750612
Blocks: 750612
|
||
Comment 3•12 years ago
|
||
Comment on attachment 626895 [details] [diff] [review]
Check for expired. Make sure expire do the right thing. r=
> #ifdef DEBUG
> NS_ASSERTION(nsAccUtils::IsTextInterfaceSupportCorrect(mGeckoAccessible),
> "Does not support nsIAccessibleText when it should");
> #endif
btw you could remove the ifdef since sserts are a nop in opt builds
Attachment #626895 -
Flags: review?(trev.saunders) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla15
|
||
Comment 5•12 years ago
|
||
Comment on attachment 626895 [details] [diff] [review]
Check for expired. Make sure expire do the right thing. r=
Review of attachment 626895 [details] [diff] [review]:
-----------------------------------------------------------------
::: accessible/src/mac/mozAccessible.mm
@@ +632,2 @@
> mIsExpired = YES;
> + mGeckoAccessible = nsnull;
since you null out mGeckoAccessible then you don't need mIsExpired member. Please file follow up bug on this.
|
||
Comment 6•12 years ago
|
||
Assignee: nobody → hub
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•12 years ago
|
||
> since you null out mGeckoAccessible then you don't need mIsExpired member.
> Please file follow up bug on this.
Filed as bug 758799
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: FIXED → ---
|
|
Assignee | |
Updated•12 years ago
|
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•