Closed
Bug 758561
Opened 13 years ago
Closed 12 years ago
"ASSERTION: Mask layer has invalid transform"
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: jruderman, Assigned: nrc)
References
Details
(Keywords: assertion, regression, testcase)
Attachments
(4 files, 1 obsolete file)
|
(deleted),
text/html
|
Details | |
|
(deleted),
text/plain
|
Details | |
|
(deleted),
patch
|
nrc
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: Mask layer has invalid transform.: 'maskIs2D && maskTransform.HasOnlyIntegerTranslation()', file Layers.h, line 704
###!!! ASSERTION: Mask layer has invalid transform.: 'maskTranslation.HasOnlyIntegerTranslation()', file gfx/layers/Layers.cpp, line 380
The first assertion is part of code added in:
changeset: f3443acc097c
user: Nicholas Cameron
summary: Bug 716439; mask layer - member, getter, setter, dumping. r=roc
The second assertion is part of code added in:
changeset: f7b8deeb0cc4
user: Nicholas Cameron
summary: Bug 716439; creating mask layers. r=roc
|
Reporter | |
Comment 1•13 years ago
|
||
Assignee: nobody → ncameron
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #627603 -
Flags: review?(roc)
Comment on attachment 627603 [details] [diff] [review]
fix - don't build masks for empty layers
Review of attachment 627603 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/base/FrameLayerBuilder.cpp
@@ +2796,5 @@
> // don't build an unnecessary mask
> if (aClip.mRoundedClipRects.IsEmpty() ||
> + aRoundedRectClipCount <= 0 ||
> + boundingRect.height == 0 ||
> + boundingRect.width == 0) {
boundingRect.IsEmpty()
Attachment #627603 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
updated according to comment - carrying r=roc
Attachment #627603 -
Attachment is obsolete: true
Attachment #627608 -
Flags: review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 6•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cc3b4fc60c5
Should this have a test?
|
|
Assignee | |
Comment 7•13 years ago
|
||
(In reply to Ryan VanderMeulen from comment #6)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/9cc3b4fc60c5
>
> Should this have a test?
Yes, it probably should, I'll make one tomorrow.
|
||
Comment 8•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 9•13 years ago
|
||
Attachment #628200 -
Flags: review?(roc)
|
|
Assignee | |
Comment 10•13 years ago
|
||
Re-opened to add test
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #628200 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 11•13 years ago
|
||
Checkin-needed for test (https://bugzilla.mozilla.org/attachment.cgi?id=628200) only, please.
Keywords: checkin-needed
|
|
||
Comment 12•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/11c39e974c4d
Sorry for the delay...
Flags: in-testsuite? → in-testsuite+
Keywords: checkin-needed
|
|
||
Comment 13•12 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 13 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•