Closed Bug 758698 Opened 13 years ago Closed 11 years ago

aurora page mis-sniffs Tablet and tries giving "undefined"

Categories

(www.mozilla.org :: Pages & Content, defect, P3)

All
Android
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: joe, Assigned: pmac)

References

(Blocks 1 open bug)

Details

(Whiteboard: [kb=1127541] u=user c=aurora p=1 r=123137 b=stage)

Attachments

(2 files)

Going to mozilla.org/aurora on an Asus Transformer ends up with neither desktop nor Android builds being offered; instead, we get "undefined" as a link.
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
I still see this. It is impossible to get aurora from aurora.mozilla.org, but I can get it from www.mozilla.org/firefox/channel Jennifer, do you know who this bug should be referred to?
Severity: normal → major
Flags: needinfo?(jbertsch)
Hi Joe and Gary- Are you the "undefined" error when the page load on the tablet (before clicking on the download button) or after clicking on the download button? That will help direct us to the right team. Thanks, Jen
Flags: needinfo?(jbertsch)
Flags: needinfo?(jbertsch)
Two more questions: Are you seeing the Android download button (it says "for Android" on it) or the desktop download button? Also, could you attach a screenshot of what is happening on your tablet? Thx!
Flags: needinfo?(jbertsch)
Attached image screenshot (deleted) —
Hopefully this helps!
Flags: needinfo?(jbertsch)
That helped a lot, actually. Could you please go back onto your tablet, and switch from desktop to mobile on the little purple button in the upper right corner and let me know if the correct download works then?
Flags: needinfo?(jbertsch)
> Could you please go back onto your tablet, and switch from desktop to mobile > on the little purple button in the upper right corner and let me know if the > correct download works then? Switching to mobile makes the link work properly.
Flags: needinfo?(jbertsch)
Thanks for helping us out with this Gary! We will be adding it to an upcoming sprint.
Flags: needinfo?(jbertsch)
Priority: -- → P2
Whiteboard: u=user c=php p=1
Target Milestone: --- → Future
Assignee: nobody → hhabstritt.bugzilla
Severity: major → normal
Priority: P2 → P3
Whiteboard: u=user c=php p=1 → u=user c=aurora p=1
This is partially fixed in Bug 725545. The download link is all.html on Android, though. (It should be all-aurora.html) https://www-dev.allizom.org/en-US/firefox/aurora/
Depends on: 725545
Whiteboard: u=user c=aurora p=1 → [kb=1127541] u=user c=aurora p=1
Almost have a patch for this. Will try to post it for review tomorrow.
Assignee: hhabstritt.bugzilla → pmac
Attached patch Proposed fix (deleted) — Splinter Review
You can see this in action on my dev server: http://bedrock.dev.pmac.io/en-US/firefox/aurora/
Attachment #823377 - Flags: review?(kohei.yoshino)
The above URL works for me. Gerv
Comment on attachment 823377 [details] [diff] [review] Proposed fix Review of attachment 823377 [details] [diff] [review]: ----------------------------------------------------------------- The download button on the dev site returned a link to apk instead of undefined. So looks good, but what the expected behavior here? I have thought the button should just link to /firefox/all-aurora.html even when browsed on Android, because this is a product page for desktop. As I said in my comment 12, the link has pointed /firefox/all.html on trunk. https://www-dev.allizom.org/en-US/firefox/aurora/ Note that http://www.mozilla.org/en-US/firefox/beta/ also points /firefox/all.html -- it's also a bug; should link to /firefox/all-beta.html (or https://play.google.com/store/apps/details?id=org.mozilla.firefox_beta)
Attachment #823377 - Flags: review?(kohei.yoshino) → review+
We may be able to offer unified download experience once the Aurora and Beta pages are migrated to Bedrock. I don't know when it'll happen, though.
:kohei those are great questions. The buttons on bedrock will offer the android download if you're browsing w/ android, so I thought it best to go with that. I doubt many people looking to download Fx Aurora for android will notice the "mobile" toggle in the upper right when a bright green download button is staring them in the face. I'd lean toward having the button give the apk and also fixing the beta button which should point to the Play store.
:pmac sounds good to me. People who are looking for Aurora may visit /firefox/aurora/ anyway as Google shows that URL in search results even on mobile or tablet devices. (I just tested with User Agent Switcher.)
Cool. Do you happen to know if there's a bug for that Beta button you mentioned :kohei? I can file if not. And unless there are objections I'm going to commit this.
(In reply to Paul McLanahan [:pmac] from comment #22) > Cool. Do you happen to know if there's a bug for that Beta button you > mentioned :kohei? I can file if not. I don't think there's an existing bug on the Beta button. > And unless there are objections I'm going to commit this. r107901, a part of Bug 725545, may also have to be marged to trunk.
Ah yes. Good catch. I'll look at that bug too.
Component: General → Pages & Content
OS: Linux → Android
Hardware: x86_64 → All
Target Milestone: Future → ---
Merged full fix to stage in r123137.
Whiteboard: [kb=1127541] u=user c=aurora p=1 → [kb=1127541] u=user c=aurora p=1 r=123137 b=stage
Merged to prod in r123138.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: