Closed
Bug 758913
Opened 13 years ago
Closed 12 years ago
Remove JSCLASS_NEW_RESOLVE_GETS_START
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: Waldo, Assigned: Waldo)
References
Details
(Whiteboard: [js:t])
Attachments
(1 file)
(deleted),
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
JSCLASS_NEW_RESOLVE_GETS_START specifies that resolve hooks be passed not just the object associated with the resolve hook, but the start object where the lookup started. But in the ECMAScript algorithms, only the resolve-hook object is passed along -- there's no way to get the start object. In order to implement the standard algorithms, then, I need to remove this flag.
There's only one use in Gecko that must be addressed (see bug 758912). It's unknown whether any other embedders use it. I've posted to the newsgroup asking if anyone does; hopefully we can figure out workarounds for anyone who does:
https://groups.google.com/forum/?fromgroups#!topic/mozilla.dev.tech.js-engine/da_9XU2XOD4
Comment 1•13 years ago
|
||
Note that this flag was added specifically for that Gecko use, by the way.
Assignee | ||
Comment 2•13 years ago
|
||
This depends on bug 758912 landing first, of course.
The newsgroup post got no responses from anyone else using this, so it seems possible that Gecko was the only user (especially given what comment 1 says), and we need not worry about breaking any JSAPI clients.
Attachment #630388 -
Flags: review?(dmandelin)
Updated•13 years ago
|
Attachment #630388 -
Flags: review?(dmandelin) → review+
Updated•13 years ago
|
Whiteboard: [js:t]
Assignee | ||
Comment 3•12 years ago
|
||
The prereq just got completed, so landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/026eb5f84c55
And a good thing, too, because the DOM accessor perf work needs a JSCLASS_* flag. :-D
Excelsior!
Target Milestone: --- → mozilla16
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•