Closed
Bug 759346
Opened 12 years ago
Closed 12 years ago
Ctrl+ช (The key is '+/=' key on ANSI keyboard layout) doesn't work as Ctrl++ but work as so on IE
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
https://bugzilla.mozilla.org/show_bug.cgi?id=756811#c16
> Ekanan Ketunuti 2012-05-29 08:00:32 PDT
>
> On Thai keyboard I use Ctrl and ช (+/= key in English) rather than Ctrl and Shift and ๅ.
>
> Since cset c9ce0e49040a I cannot use Ctrl and ช for zoom-in.
The key's virtual keycode is VK_OEM_PLUS. It's odd, the key cannot input '+' and '1' key can input '+' with Shift key. So, the key shouldn't be VK_OEM_PLUS. However, other applications checks the virtual keycode for kicking shortcut key handlers. So, we should add special case for it.
This is a regression of bug 630810, so, this must be fixed on Fx15.
Assignee | ||
Comment 1•12 years ago
|
||
testing on tryserver:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1
This makes inconsistency between other platforms on some keyboard layout. However, it's better to emulate native application manners.
Attachment #627987 -
Flags: review?(jmathies)
Updated•12 years ago
|
Attachment #627987 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 2•12 years ago
|
||
Target Milestone: --- → mozilla15
Comment 3•12 years ago
|
||
Thank you for fixing this!
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Ekanan Ketunuti from comment #3)
> Thank you for fixing this!
Thank *you* for your reporting. That always helps us.
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7f259a56c7c0
(In reply to Ekanan Ketunuti from comment #3)
> Thank you for fixing this!
The fix will be present in tomorrow's Nightly / Firefox 15 when it reaches aurora/beta/release :-)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 6•12 years ago
|
||
This is fixed, and possibly uncommon, so untracking.
tracking-firefox15:
? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•