Closed Bug 75936 Opened 24 years ago Closed 24 years ago

Search UI: File multi folder/group results doesn't work right in most cases.

Categories

(SeaMonkey :: MailNews: Message Display, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: laurel, Assigned: naving)

References

Details

(Whiteboard: [nsbeta1+][PDT+] Have fix)

Attachments

(2 files)

Using apr13 commercial build When trying to use the File button in search ui to file results which span different folders or groups on an account to a destination folder which is POP or in Local Folders, only one folder/group's messages are filed. Tried both contiguous and non-contiguous selections. Cases which don't work: IMAP --> IMAP across accounts IMAP --> POP account or Local Folders POP --> POP same account POP --> Local Folders News (copy) --> POP account or Local Folders Cases which do work: IMAP --> IMAP same account News (copy) --> IMAP account
Keywords: nsbeta1
QA Contact: esther → laurel
marking nsbeta1+
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9
reassigning to self
Assignee: gayatrib → naving
These cases workforme on 041604 win32 bits POP --> POP same account POP --> Local Folders
Taking back my previous comment. Filing mutiple messages from different folder to another folder is broken.
moving to mozilla0.9.1
Priority: -- → P2
Target Milestone: mozilla0.9 → mozilla0.9.1
Depends on: 77232
No longer depends on: 77232
Blocks: 77232
fix checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
reopening; something is wrong
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
fix checked in.
Status: REOPENED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
I'm not done with verification testing, but am seeing some problems when filing from a search result over IMAP account, am not sorting the results (trying to keep sorting out of the issue), happens with contiguous or non-contiguous selection: 1) Win98, macOS9: IMAP --> IMAP within acct works when filing messages which cross 2 folders, but doesn't work filing messages which span more than 2 folders -- not all the messages are removed from the search, nor do they all appear in the destination. 2) MacOS9: IMAP --> LocalFolder doesn't even work when filing two messages spanning two folders. In both cases above, filing multiple (>3) selection from search results residing in same folder does work. I'm going to keep testing before reopening, since I want to be sure of the results of even some simple scenarios. I just wanted to report some progress.
Try doing only one message from each folder for multiple folders. Looks like the copy state is not getting cleared for multiple messages from one folder. Will have to reopened.
When I tried each case, I was only selecting one message from each folder. It's when I selected 3 messages each from a different folder is when I started failing (win98), mac only 2 in the file to local case. It's not working and seems very inconsistent. I'll reopen. Another note: Because search UI File is broken in modern skin, this all was done with classic skin.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch proposed fix. (deleted) — Splinter Review
No need to use copyservice; need review, david.
sr=bienvenu
fix checked in.
Status: REOPENED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
Not through with all cases yet, but... so far found that IMAP --> Local Folders or POP account is not working on any platform. Even filing 2 results/msgs spanning 2 folders (one from each folder) from an IMAP account to local folder will only file one of the messages.
Using simple cases results crossing 2-3 folders, nothing fancy with may22 commercial build: 1. OK: IMAP --> IMAP cases work allright. Same server or cross servers. 2. NOT OK: IMAP --> local/pop doesn't work for results spanning multi folders. (Does work if the results only fall in one folder.) 3. NOT OK: POP --> local/pop doesn't work for results spanning multi folders to destination on same account or not. (Does work if results only fall in one folder.) 4. NOT OK: News --> local/pop (copy) doesn't work for results spanning multi groups. (Does work if results selected all fall in one group.) 5. NOT OK: News --> imap doesn't work for results spanning multi groups. (Does work if results selected all fall in one group.) Since there are many cases, I tried these using File. I will briefly double-check some cases for delete as it might also logically fail for deleting results spanning multiple folders. So, am reopening based on the number of (File) cases which don't work. If we want to log any separate issues, let me know.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
moving to 0.9.2
Target Milestone: mozilla0.9.1 → mozilla0.9.2
There are just so many cases. I will do a better job of testing all the cases before I mark it fixed again.
I have checked all the cases that were not working for filing messages from the search window IMAP -> POP/local POP/local -> POP/local NEWS -> IMAP NEWS -> POP/local I will attach the patch that fixes the above To make sure that I have not introduced regressions in 3 pane move/copy, I have tested multiple messages and it works IMAP -> POP/local POP/local -> IMAP POP/local -> POP/local NEWS ->POP/local NEWS -> IMAP
Attached patch proposed fix. (deleted) — Splinter Review
The fix for local is basically to clear the copyState and then call OnStopCopy(NS_OK) for both move & copy. The fix for the IMAP is to set sendEndCopyNotification so that later OnStopCopy(NS_OK) is called. I need review, david ?
Whiteboard: [nsbeta1+] → [nsbeta1+] Have fix
did you try single message versions of all the 3 pane move/copy permuations? Also, did you try move AND copy, not move/copy?
I have tested single version and I have done move & copy for 3 pane.
r=bienvenu
adding PDT+. Please check into the trunk as soon as possible.
Whiteboard: [nsbeta1+] Have fix → [nsbeta1+][PDT+] Have fix
sr=mscott
a=chofmann for the trunk
Blocks: 83989
fix checked in.
Status: REOPENED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
OK with june21 commercial trunk win98. Some inconsistent failures, but retrying the same type of multiple file from search will succeed. Don't know why intermittent failures, but generally OK. There are so many cases anyway, if it succeeds once, hey - we're good. At some point when I have more time to investigate and do more extensive cases, I'll log some separate issues. Still need to check other platforms...
OK, I've tried all platforms and the main kind of filing from search which will fail most often is going from News to IMAP when the search results span more than one newsgroup. Mac particularly has a hard time with this in my experience, whereas on the other platforms I've at least been able to have a successful File/Copy at least a couple times. I would say at this point that this bug is OK/verified, although I'm going to try a little more next week. At that time if News-->IMAP is still a problem I'll log a separate bug. In any event, that case (spanning multiple groups) would probably not be a common one and in no way would be a stopper kind of issue. OK with june22 commercial trunk builds on linux rh6.2, win98, mac OS 9.0.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
Component: MailNews: Search → MailNews: Message Display
QA Contact: laurel → search
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: