Closed
Bug 760076
Opened 12 years ago
Closed 12 years ago
Wrapper construct users Wrapper::GET rather than Wrapper::CALL
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
This makes no sense to me. It also means that COW-ed objects can be ()-ed but not new-ed.
This was the source of some nastiness over in bug 756173. I'll write up a patch right now.
|
Assignee | |
Comment 1•12 years ago
|
||
Attaching a patch. Pushed to try here: https://tbpl.mozilla.org/?tree=Try&rev=4f003eaf3822
Flagging jorendorff for review in case he remembers some reason why it was supposed to be like this.
Attachment #628705 -
Flags: review?(jorendorff)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 628705 [details] [diff] [review]
Make |construct| use Wrapper::CALL. v1
Stealing the review here as this was my fault... It looks like when I added the CALL permission during the brain transplant scramble, I simply forgot to update construct to match call.
Attachment #628705 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Looks green. Pushed to try:
http://hg.mozilla.org/integration/mozilla-inbound/rev/d3d7c919fb50
Target Milestone: --- → mozilla15
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•