We should handle the scenario where the manifest has changed between the cron job picking up the change (at midnight, or whatever) and now (the review time). We will be reviewing the manifest now (correctly) but if the Version object is going to store the manifest at the time the cron job created the version (i.e. midnight) then review approval will incorrectly be associated with that. What's more, the change would be picked up by the cron job the following midnight and possibly flagged for re-review even though nothing has changed between the review time and midnight. My preference is to update the stored manifest contents in the current Version object when the review is submitted. The alternative is creating a new version and associating the review with that - I suspect that will be more complicated.

Clicking the approve button could trigger an update. If the manifest is unchanged the approval goes through, otherwise it could reprompt. see also: [Bug 757297] Add a "Refresh" button next to the Manifest URL

Now that we have the cron to pull in manifest changes each night, I don't think we need this bug anymore.

(In reply to Rob Hudson [:robhudson] from comment #2) > Now that we have the cron to pull in manifest changes each night, I don't > think we need this bug anymore. That doesn't really follow... I filled this bug /after/ the cron job went live (hence the mention in comment #0) - its to stop a reviewed app ending up in the re-review queue on the following night because there was a change after the previous night, but before the approval took place.