See attached screenshot; the bottom-right thumbnail is of an RTL page (http://www.bbc.co.uk/persian/mobile/index.shtml) and has a bunch of black space. I believe the code in AndroidBridge::TakeScreenshot that calls GetScrollWidth and GetScrollHeight to calculate srcW and srcH also needs to update srcX and srcY to be the top-left corner of the page (it currently assumes 0,0 is top-left).

Not a 14 blocker, but we'd like to approve a patch

Comment on attachment 629311 [details] [diff] [review] Use GetRootBounds instead of GetScrollWidth/GetScrollHeight This works fine, even on my weird RAZR.

Sorry, I had to back this out on inbound because the patch depends on bug 755070 which was backed out for crashes: https://hg.mozilla.org/integration/mozilla-inbound/rev/d7b8fe3834b9

Re-landed since it doesn't functionally depend on bug 755070, it just needs some hand-merging. https://hg.mozilla.org/integration/mozilla-inbound/rev/8afb46816482

Backed out: https://hg.mozilla.org/mozilla-central/rev/d7b8fe3834b9

Comment on attachment 629311 [details] [diff] [review] Use GetRootBounds instead of GetScrollWidth/GetScrollHeight [Approval Request Comment] Bug caused by (feature/regressing bug #): 748384 User impact if declined: thumbnails on about:home for RTL pages may not render properly Testing completed (on m-c, etc.): on m-c Risk to taking this patch (and alternatives if risky): low risk of screwing up thumbnails in general. android-only String or UUID changes made by this patch: none

Comment on attachment 629311 [details] [diff] [review] Use GetRootBounds instead of GetScrollWidth/GetScrollHeight Clearing aurora approval flag since this just rode the train from m-c into Aurora. Requesting beta approval instead (i.e. approval to land on the 14 branch).

Thumbnails are not displayed on Aurora 15.0a2 2012-06-07, Nightly 16.0a1 2012-06-08 and Firefox Mobile Beta 14.0b6. Bug 762899 tracks the issue. Leaving the bug open since it can't be verified.