Closed Bug 760724 Opened 13 years ago Closed 12 years ago

Reader Mode: Update all icons in the URL bar and awesome screen

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox15 verified, firefox16 verified, firefox17 verified)

VERIFIED FIXED
Firefox 16
Tracking Status
firefox15 --- verified
firefox16 --- verified
firefox17 --- verified

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(1 file)

Ian: "Here are some updated icons for the urlbar, to make the lock, stop/go/search, and reader mode icons feel more in line. Please replace all of these at the same time. http://cl.ly/3O42022J1H0N2E1Y3K11 "
Assignee: nobody → lucasr.at.mozilla
Lucas, FYI I just checked the zip file and everything you should need is already in there for the URL bar. It includes: * Search icon * Stop icon * Go icon * Lock icons (green and blue) * Reader mode icon
drawable-xlarge-*/ and drawable-sw600dp-*/ are the same resources. Probably we can file a bug to make this duplication in Makefile directly (like create appropriate folders and copy stuff from drawable-xlarge-*/ )
Here's a summary of what I've done with the icons: M mobile/android/base/Makefile.in M mobile/android/base/resources/drawable-hdpi/ic_awesomebar_go.png M mobile/android/base/resources/drawable-hdpi/ic_awesomebar_search.png M mobile/android/base/resources/drawable-hdpi/reader.png M mobile/android/base/resources/drawable-hdpi/site_security_identified.png M mobile/android/base/resources/drawable-hdpi/site_security_verified.png M mobile/android/base/resources/drawable-hdpi/urlbar_stop.png M mobile/android/base/resources/drawable-land-hdpi-v14/ic_awesomebar_go.png M mobile/android/base/resources/drawable-land-hdpi-v14/ic_awesomebar_search.png M mobile/android/base/resources/drawable-land-hdpi-v14/site_security_identified.png M mobile/android/base/resources/drawable-land-hdpi-v14/site_security_verified.png M mobile/android/base/resources/drawable-land-hdpi-v14/urlbar_stop.png M mobile/android/base/resources/drawable-land-mdpi-v14/ic_awesomebar_go.png M mobile/android/base/resources/drawable-land-mdpi-v14/ic_awesomebar_search.png M mobile/android/base/resources/drawable-land-mdpi-v14/site_security_identified.png M mobile/android/base/resources/drawable-land-mdpi-v14/site_security_verified.png M mobile/android/base/resources/drawable-land-mdpi-v14/urlbar_stop.png M mobile/android/base/resources/drawable-land-xhdpi-v14/ic_awesomebar_go.png M mobile/android/base/resources/drawable-land-xhdpi-v14/ic_awesomebar_search.png M mobile/android/base/resources/drawable-land-xhdpi-v14/site_security_identified.png M mobile/android/base/resources/drawable-land-xhdpi-v14/site_security_verified.png M mobile/android/base/resources/drawable-land-xhdpi-v14/urlbar_stop.png M mobile/android/base/resources/drawable-sw600dp-hdpi/urlbar_stop.png M mobile/android/base/resources/drawable-sw600dp-mdpi/urlbar_stop.png M mobile/android/base/resources/drawable-sw600dp-xhdpi/urlbar_stop.png M mobile/android/base/resources/drawable-xhdpi-v11/ic_awesomebar_go.png M mobile/android/base/resources/drawable-xhdpi-v11/ic_awesomebar_search.png M mobile/android/base/resources/drawable-xhdpi-v11/reader.png M mobile/android/base/resources/drawable-xhdpi-v11/site_security_identified.png M mobile/android/base/resources/drawable-xhdpi-v11/site_security_verified.png M mobile/android/base/resources/drawable-xhdpi-v11/urlbar_stop.png M mobile/android/base/resources/drawable-xlarge-hdpi/urlbar_stop.png M mobile/android/base/resources/drawable-xlarge-mdpi/urlbar_stop.png M mobile/android/base/resources/drawable-xlarge-xhdpi/urlbar_stop.png M mobile/android/base/resources/drawable/ic_awesomebar_go.png M mobile/android/base/resources/drawable/ic_awesomebar_search.png M mobile/android/base/resources/drawable/reader.png M mobile/android/base/resources/drawable/site_security_identified.png M mobile/android/base/resources/drawable/site_security_verified.png M mobile/android/base/resources/drawable/urlbar_stop.png A mobile/android/base/resources/drawable-land-hdpi-v14/reader.png A mobile/android/base/resources/drawable-land-mdpi-v14/reader.png A mobile/android/base/resources/drawable-land-xhdpi-v14/reader.png A mobile/android/base/resources/drawable-sw600dp-hdpi/ic_awesomebar_go.png A mobile/android/base/resources/drawable-sw600dp-hdpi/ic_awesomebar_search.png A mobile/android/base/resources/drawable-sw600dp-hdpi/reader.png A mobile/android/base/resources/drawable-sw600dp-hdpi/site_security_identified.png A mobile/android/base/resources/drawable-sw600dp-hdpi/site_security_verified.png A mobile/android/base/resources/drawable-sw600dp-mdpi/ic_awesomebar_go.png A mobile/android/base/resources/drawable-sw600dp-mdpi/ic_awesomebar_search.png A mobile/android/base/resources/drawable-sw600dp-mdpi/reader.png A mobile/android/base/resources/drawable-sw600dp-mdpi/site_security_identified.png A mobile/android/base/resources/drawable-sw600dp-mdpi/site_security_verified.png A mobile/android/base/resources/drawable-sw600dp-xhdpi/ic_awesomebar_go.png A mobile/android/base/resources/drawable-sw600dp-xhdpi/ic_awesomebar_search.png A mobile/android/base/resources/drawable-sw600dp-xhdpi/reader.png A mobile/android/base/resources/drawable-sw600dp-xhdpi/site_security_identified.png A mobile/android/base/resources/drawable-sw600dp-xhdpi/site_security_verified.png A mobile/android/base/resources/drawable-xlarge-hdpi/ic_awesomebar_go.png A mobile/android/base/resources/drawable-xlarge-hdpi/ic_awesomebar_search.png A mobile/android/base/resources/drawable-xlarge-hdpi/reader.png A mobile/android/base/resources/drawable-xlarge-hdpi/site_security_identified.png A mobile/android/base/resources/drawable-xlarge-hdpi/site_security_verified.png A mobile/android/base/resources/drawable-xlarge-mdpi/ic_awesomebar_go.png A mobile/android/base/resources/drawable-xlarge-mdpi/ic_awesomebar_search.png A mobile/android/base/resources/drawable-xlarge-mdpi/reader.png A mobile/android/base/resources/drawable-xlarge-mdpi/site_security_identified.png A mobile/android/base/resources/drawable-xlarge-mdpi/site_security_verified.png A mobile/android/base/resources/drawable-xlarge-xhdpi/ic_awesomebar_go.png A mobile/android/base/resources/drawable-xlarge-xhdpi/ic_awesomebar_search.png A mobile/android/base/resources/drawable-xlarge-xhdpi/reader.png A mobile/android/base/resources/drawable-xlarge-xhdpi/site_security_identified.png A mobile/android/base/resources/drawable-xlarge-xhdpi/site_security_verified.png
That makes all icons in awesomebar and toolbar have the same number of sizes/version than the stop button.
Attachment #631940 - Flags: review?(sriram)
(In reply to Sriram Ramasubramanian [:sriram] from comment #2) > drawable-xlarge-*/ and drawable-sw600dp-*/ are the same resources. > Probably we can file a bug to make this duplication in Makefile directly > (like create appropriate folders and copy stuff from drawable-xlarge-*/ ) Filed bug 763566 to track this.
Comment on attachment 631940 [details] [diff] [review] Update all icons in the URL bar and awesome screen Review of attachment 631940 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #631940 - Flags: review?(sriram) → review+
Comment on attachment 631940 [details] [diff] [review] Update all icons in the URL bar and awesome screen Part of Reader Mode effort, also improves coverage of several icons for different screen sizes and densities.
Attachment #631940 - Flags: approval-mozilla-aurora?
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Comment on attachment 631940 [details] [diff] [review] Update all icons in the URL bar and awesome screen [Triage Comment] Reader mode is not slated for FF15 in the current draft of the product roadmap.
Attachment #631940 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Comment on attachment 631940 [details] [diff] [review] Update all icons in the URL bar and awesome screen [Triage Comment] Just an image swap (and addition). Low risk - approved for Beta 15.
Attachment #631940 - Flags: approval-mozilla-aurora- → approval-mozilla-beta+
Forgot to mention that landing 7" tablet support was the main driver for approving.
Alex, Sriram, doesn't it have to land in Aurora as well?
(In reply to Lucas Rocha (:lucasr) from comment #14) > Alex, Sriram, doesn't it have to land in Aurora as well? It landed in Nightly 16 (see Target Milestone).
I believe it's in aurora as a part of the merge that happened. This patch wasn't there in beta alone.
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: