Closed
Bug 760896
Opened 12 years ago
Closed 12 years ago
Use CommonUtils.json* in AitC Storage module
Categories
(Web Apps Graveyard :: AppsInTheCloud, defect)
Web Apps Graveyard
AppsInTheCloud
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: anant, Assigned: anant)
Details
(Whiteboard: [blocking-aitc+][qa-])
Attachments
(1 file)
|
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
The Storage modules have manual routines to save and load JSON from/to disk, while bug 760448 added error reporting to CommonUtils.jsonLoad. We should move to using that instead.
|
||
Updated•12 years ago
|
Whiteboard: [blocking-aitc-]
|
Assignee | |
Comment 1•12 years ago
|
||
Though it was decided this wasn't a blocker at the last triage meeting, bug 748977 is a blocker, and I think the easiest way to solve that bug is by fixing this one. 2 birds with 1 stone, so marking as blocker.
Whiteboard: [blocking-aitc-] → [blocking-aitc+]
|
|
||
Comment 2•12 years ago
|
||
(In reply to Anant Narayanan [:anant] from comment #1)
> Though it was decided this wasn't a blocker at the last triage meeting, bug
> 748977 is a blocker, and I think the easiest way to solve that bug is by
> fixing this one. 2 birds with 1 stone, so marking as blocker.
Are you referring to the right bug here? bug 748977 is the bug about front-end firefox UX for the AITC dashboard.
|
|
Assignee | |
Comment 3•12 years ago
|
||
Bah, copy-paste fail. I meant bug 760905.
|
|
Assignee | |
Comment 4•12 years ago
|
||
I have a WIP patch for this, just needs some cleanup and tweaks to tests so they pass again.
Assignee: nobody → anant
|
|
Assignee | |
Comment 5•12 years ago
|
||
My theory is that this will make bug 760905 go away. A theory that I'm testing at https://tbpl.mozilla.org/?tree=Try&rev=7c32bb38a471...
Attachment #638456 -
Flags: review?(gps)
|
|
Assignee | |
Updated•12 years ago
|
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86 → All
|
||
Comment 6•12 years ago
|
||
Comment on attachment 638456 [details] [diff] [review]
User CommonUtils.json* for storage queue
Review of attachment 638456 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me. Yay, less lines of source \o/
Attachment #638456 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
Whiteboard: [blocking-aitc+] → [blocking-aitc+], [fixed in services]
|
|
||
Comment 8•12 years ago
|
||
Is there anything to verify here from an end-user perspective?
Whiteboard: [blocking-aitc+], [fixed in services] → [blocking-aitc+], [fixed in services], [qa?]
|
|
Assignee | |
Comment 9•12 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #8)
> Is there anything to verify here from an end-user perspective?
Nope!
|
|
||
Updated•12 years ago
|
Whiteboard: [blocking-aitc+], [fixed in services], [qa?] → [blocking-aitc+], [fixed in services], [qa-]
|
|
||
Comment 10•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [blocking-aitc+], [fixed in services], [qa-] → [blocking-aitc+][qa-]
|
||
Updated•6 years ago
|
Product: Web Apps → Web Apps Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•