Closed
Bug 762091
Opened 12 years ago
Closed 12 years ago
rm enclosing->global() != obj->getParent() check in CallObject::create
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 765956
People
(Reporter: luke, Assigned: luke)
References
Details
(Whiteboard: [js:t])
If I understand correctly, this isn't necessary with cpg. Is that right Brian?
Comment 1•12 years ago
|
||
I think this check is still necessary for objects in non-compileAndGo scripts, as the initial shape of the object is derived from the script's bindings and those bindings will have a NULL parent for non-CNG scripts. Of course, with CPG there is no sense in distinguishing CNG vs. non-CNG scripts (given special handling for scripts which can run against non-global, non-scope scopes) so the CNG vs. non-CNG distinction should be removed itself.
Comment 2•12 years ago
|
||
To be clear, as is the check does not need to be performed for call objects created in compileAndGo code.
Assignee | ||
Comment 3•12 years ago
|
||
Ohh, I see. I didn't realize the role TypeScript::SetScope played in all this. Gross, so we can rip out pretty much all that stuff with CNG.
Updated•12 years ago
|
Whiteboard: [js:t]
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•