Kelsey Gilbert [:jgilbert] Assignee
	Description • 12 years ago

We're going to be in EGL land on an increasing number of platforms, and working more with extensions for EGL for EGLImage, EGLSync, and hopefully eventually EGLStream.

	Kelsey Gilbert [:jgilbert] Assignee
	Comment 2 • 12 years ago

Adds NS_ERRORs when the extensions are 'supported', but their functions are not exposed.

	Benoit Jacob [:bjacob] (mostly away)
	Comment 3 • 12 years ago

Comment on attachment 630739 [details] [diff] [review]
patch

Review of attachment 630739 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContext.cpp
@@ +539,5 @@
>  #else
>      const bool once = true;
>  #endif
>  
> +    mAvailableExtensions.Load(extensions, sExtensionNames, !once);

To remove the negation here and generally be more explicit, maybe you could use a |firstTime| variable here.

::: gfx/gl/GLContext.h
@@ +1568,2 @@
>          bool& operator[](size_t index) {
> +            NS_ASSERTION(index < Size, "out of range");

This should be a MOZ_ASSERT similar to bug 732607.

	Kelsey Gilbert [:jgilbert] Assignee
	Comment 4 • 12 years ago

Carrying forward r+ with nit fixes.

	Kelsey Gilbert [:jgilbert] Assignee
	Comment 5 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/27d0a3ecfe95

	Ed Morley [:emorley]
	Comment 6 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/27d0a3ecfe95

	James Willcox (:snorp) (jwillcox@mozilla.com) (he/him)
	Comment 7 • 12 years ago

Comment on attachment 632051 [details] [diff] [review]
patch with nits fixed

[Approval Request Comment]
Required by bug 728524

	Lukas Blakk [:lsblakk] use ?needinfo
	Comment 8 • 12 years ago

Comment on attachment 632051 [details] [diff] [review]
patch with nits fixed

Approving supporting patches for bug 687267

	James Willcox (:snorp) (jwillcox@mozilla.com) (he/him)
	Comment 9 • 12 years ago

https://hg.mozilla.org/releases/mozilla-beta/rev/69b1dee11b5e