Closed
Bug 762265
Opened 12 years ago
Closed 12 years ago
Modernize EGL extension detection, similar to GLContext's IsExtensionSupported
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: jgilbert, Assigned: jgilbert)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
jgilbert
:
review+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We're going to be in EGL land on an increasing number of platforms, and working more with extensions for EGL for EGLImage, EGLSync, and hopefully eventually EGLStream.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #630734 -
Flags: review?(bjacob)
|
|
Assignee | |
Updated•12 years ago
|
OS: Windows 7 → All
Hardware: x86_64 → All
|
|
Assignee | |
Comment 2•12 years ago
|
||
Adds NS_ERRORs when the extensions are 'supported', but their functions are not exposed.
Attachment #630734 -
Attachment is obsolete: true
Attachment #630734 -
Flags: review?(bjacob)
Attachment #630739 -
Flags: review?(bjacob)
|
|
Assignee | |
Updated•12 years ago
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 630739 [details] [diff] [review]
patch
Review of attachment 630739 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/gl/GLContext.cpp
@@ +539,5 @@
> #else
> const bool once = true;
> #endif
>
> + mAvailableExtensions.Load(extensions, sExtensionNames, !once);
To remove the negation here and generally be more explicit, maybe you could use a |firstTime| variable here.
::: gfx/gl/GLContext.h
@@ +1568,2 @@
> bool& operator[](size_t index) {
> + NS_ASSERTION(index < Size, "out of range");
This should be a MOZ_ASSERT similar to bug 732607.
Attachment #630739 -
Flags: review?(bjacob) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Carrying forward r+ with nit fixes.
Attachment #630739 -
Attachment is obsolete: true
Attachment #632051 -
Flags: review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Target Milestone: --- → mozilla16
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 7•12 years ago
|
||
Comment on attachment 632051 [details] [diff] [review]
patch with nits fixed
[Approval Request Comment]
Required by bug 728524
Attachment #632051 -
Flags: approval-mozilla-beta?
|
||
Comment 8•12 years ago
|
||
Comment on attachment 632051 [details] [diff] [review]
patch with nits fixed
Approving supporting patches for bug 687267
Attachment #632051 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Updated•12 years ago
|
status-firefox15:
--- → affected
status-firefox16:
--- → fixed
|
|
||
Comment 9•12 years ago
|
||
|
||
Updated•12 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•