Closed
Bug 762588
Opened 13 years ago
Closed 13 years ago
channel-prefs.js is at the wrong location in FF-on-XR setups
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 16
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
robert.strong.bugs
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
In Xulrunner applications, the defaults/pref/ directory under the application directory is not used for preferences, which means channel-prefs.js, being installed there unconditionally, is never going to be read.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Attachment #631062 -
Flags: review?(robert.bugzilla)
Assignee | ||
Updated•13 years ago
|
status-firefox14:
--- → affected
status-firefox15:
--- → affected
Updated•13 years ago
|
Attachment #631062 -
Flags: review?(robert.bugzilla) → review+
Comment 2•13 years ago
|
||
FYI: The changes that caused this bug also landed on Aurora and are on beta as well now.
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to Robert Strong [:rstrong] (do not email) from comment #2)
> FYI: The changes that caused this bug also landed on Aurora and are on beta
> as well now.
Which is why I had set status-firefox14: affected :)
Assignee | ||
Comment 4•13 years ago
|
||
Target Milestone: --- → Firefox 16
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 631062 [details] [diff] [review]
Install channel-prefs.js in PREF_DIR when building Firefox as a XULRunner app
[Approval Request Comment]
Bug caused by bug 756325, which was a late landing on aurora (a few days before beta merge).
User impact if declined: Only a problem for people building firefox as a xulrunner application.
Risk to taking this patch (and alternatives if risky): The patch doesn't change anything for mozilla builds.
Attachment #631062 -
Flags: approval-mozilla-beta?
Attachment #631062 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Attachment #631062 -
Flags: approval-mozilla-beta?
Attachment #631062 -
Flags: approval-mozilla-beta+
Attachment #631062 -
Flags: approval-mozilla-aurora?
Attachment #631062 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 7•12 years ago
|
||
Updated•12 years ago
|
Comment 8•12 years ago
|
||
Comment on attachment 631062 [details] [diff] [review]
Install channel-prefs.js in PREF_DIR when building Firefox as a XULRunner app
Review of attachment 631062 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/app/Makefile.in
@@ +142,5 @@
> libs:: $(srcdir)/profile/channel-prefs.js
> $(NSINSTALL) -D $(DIST)/bin/defaults/pref
> $(PYTHON) $(topsrcdir)/config/Preprocessor.py $(PREF_PPFLAGS) $(ACDEFINES) $^ > $(DIST)/bin/defaults/pref/channel-prefs.js
> +else
> +PREF_JS_EXPORTS += $(srcdir)/profile/channel-prefs.js
I'm a little confused.
Isn't it useless to set PREF_JS_EXPORTS _after_ including rules.mk?
http://mxr.mozilla.org/comm-central/search?string=PREF_JS_EXPORTS&case=on
Assignee | ||
Comment 9•12 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #8)
> Comment on attachment 631062 [details] [diff] [review]
> Install channel-prefs.js in PREF_DIR when building Firefox as a XULRunner app
>
> Review of attachment 631062 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: browser/app/Makefile.in
> @@ +142,5 @@
> > libs:: $(srcdir)/profile/channel-prefs.js
> > $(NSINSTALL) -D $(DIST)/bin/defaults/pref
> > $(PYTHON) $(topsrcdir)/config/Preprocessor.py $(PREF_PPFLAGS) $(ACDEFINES) $^ > $(DIST)/bin/defaults/pref/channel-prefs.js
> > +else
> > +PREF_JS_EXPORTS += $(srcdir)/profile/channel-prefs.js
>
> I'm a little confused.
> Isn't it useless to set PREF_JS_EXPORTS _after_ including rules.mk?
> http://mxr.mozilla.org/comm-central/search?string=PREF_JS_EXPORTS&case=on
Mmmm you're right. Can you file a followup bug?
Comment 10•12 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #9)
> Can you file a followup bug?
Bug 769130 Submitted
You need to log in
before you can comment on or make changes to this bug.
Description
•