Closed
Bug 762654
Opened 12 years ago
Closed 12 years ago
Switch the 2d canvas context to new DOM bindings
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: peterv, Assigned: peterv)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Comment on attachment 631113 [details] [diff] [review]
v1
Review of attachment 631113 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/base/Makefile.in
@@ +128,5 @@
>
> LOCAL_INCLUDES += \
> -I$(topsrcdir)/js/xpconnect/src \
> -I$(topsrcdir)/js/xpconnect/wrappers \
> + -I$(topsrcdir)/content/canvas/src \
Why's that?
FWIW we're getting pretty close to being able to remove nsCanvasRenderingContext2D, if that helps here.
|
|
Assignee | |
Comment 4•12 years ago
|
||
This makes the pref for Azure canvas static, so requiring a restart after changing it.
I had to make nsIDOMCanvasRenderingContext2D_GetImageData a custom quickstub because ImageData is a non-wrappercached object with a new binding.
Attachment #631113 -
Attachment is obsolete: true
Attachment #636489 -
Flags: review?(bzbarsky)
|
||
Comment 5•12 years ago
|
||
Comment on attachment 636489 [details] [diff] [review]
v1.1
r=me
Attachment #636489 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
Target Milestone: --- → mozilla16
|
||
Comment 7•12 years ago
|
||
Sorry, I backed this out on inbound along with bug 762652 because Windows PGO builds were crashing in gfxContext::FillAzure:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a2cc88619ba
https://tbpl.mozilla.org/php/getParsedLog.php?id=13051005&tree=Mozilla-Inbound
Target Milestone: mozilla16 → ---
|
|
Assignee | |
Comment 8•12 years ago
|
||
Target Milestone: --- → mozilla16
|
||
Comment 9•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•