Closed
Bug 762891
Opened 12 years ago
Closed 12 years ago
IonMonkey: Fix ss-fannkuch phi specialization
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Another ss-fannkuch problem. There's a bunch of LValueToInt32 instructions caused by suboptimal phi specialization in some edge cases.
|
Assignee | |
Comment 1•12 years ago
|
||
GuessPhiType tries to guess the type of the phi based on the operand types. If all operands are phis we still have to visit, GuessPhiType returns MIRType_None.
The patch ensures we never propagate MIRType_None to other phis. We have to wait until we know one of the operand types and then we can propagate the type.
This + bug 762887 should make ss-fannkuch a bit faster, but especially x86 needs more work.
Attachment #631391 -
Flags: review?(dvander)
|
||
Updated•12 years ago
|
Attachment #631391 -
Flags: review?(dvander) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•