The CreateBundle() api is using a dead nsILocale param; should be removed.

since you have to change call sites anyway, can you change this to .createBundle (interCaps) while you're at it? (I only see 5 uses of this in JS the tree so it's minor)

tao can I get an r= when you have a chance.

looks good; r=tao

alecf sr=? this would be checked in *after* the tree opens for 0.9.1, on the trunk. it's not for 0.9.

I thought i'd mention that there is a real performance hit when inside nsStringBundleService::getStringBundle We are inside here like 2 seconds when we launch mozilla or gtkEmbed. It takes like 10 seconds on initial startup to register all the chrome. This bottleneck hurts. --pete

I traced it a bit further to this call: NS_OpenURI(getter_AddRefs(in), uri); inside of: nsStringBundle::InitSyncStream --pete

that OpenURI() call does an OpenInputStream() which blocks the UI thread. you might want to re-open http://bugzilla.mozilla.org/show_bug.cgi?id=26291 and discuss it there. no more discussion on the perf issue in this bug please.

Yea thanks, i just filed this one to track it. http://bugzilla.mozilla.org/show_bug.cgi?id=76682 I'll look at it now. --pete

Changing QA contact to ftang for now. Can you please verify this within development or provide a test case later on?

There are some string-usage cleanups that I would normally request under the ``it appeared in your context diff'' doctrine, and it's hard to validate the ownership model around CreateBundle(..., m_pIStringBundle) without access to the rest of the tree, but it looks like you have Done No Harm. And since you fixed some IDL case, I'm swooning with joy. sr=shaver. (I'd still like you to get an r= from someone with more commercial tree experience, because I can't see a lot of context there.)

r= sr= syd on the commercial bits

looks like you need to expand out the tabs . . . --pete

mozilla diffs have been checked in. leaf is going to checkin the commercial diffs when the commercial cvs server comes back on line either today or tomorrow; thanks leaf.

leaf checked in the comm patches. this is all checked in.