Closed
Bug 763388
Opened 12 years ago
Closed 12 years ago
Remove enablePrivilege calls from IndexedDB and FileHandle tests
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: janv, Assigned: janv)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → Jan.Varga
Status: NEW → ASSIGNED
Attachment #631837 -
Flags: review?(bent.mozilla)
Comment 2•12 years ago
|
||
Comment on attachment 631837 [details] [diff] [review]
fix
ted should review the special powers API changes.
Attachment #631837 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 3•12 years ago
|
||
try looks good:
https://tbpl.mozilla.org/?tree=Try&rev=04f82dc63a45
Comment on attachment 631837 [details] [diff] [review]
fix
Review of attachment 631837 [details] [diff] [review]:
-----------------------------------------------------------------
I'm not wild about the SpecialPowers changes (seems like you could just expose the thread manager to accomplish some of this stuff), but I'll let ted be the final judge.
::: dom/file/test/test_lockedfile_lifetimes_nested.html
@@ +23,5 @@
>
> let lockedFile = fileHandle.open();
>
> let lockedFile2;
> + SpecialPowers.executeSoonSync(function() {
SimpleTest has an executeSoon you can use. Then you won't have to make a new one in SpecialPowers.
Attachment #631837 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to ben turner [:bent] from comment #4)
> ::: dom/file/test/test_lockedfile_lifetimes_nested.html
> @@ +23,5 @@
> >
> > let lockedFile = fileHandle.open();
> >
> > let lockedFile2;
> > + SpecialPowers.executeSoonSync(function() {
>
> SimpleTest has an executeSoon you can use. Then you won't have to make a new
> one in SpecialPowers.
Ben, this one is special, see the "Sync".
It waits for the event to be processed.
I'm willing to rework it if we decide to just expose the thread manager.
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Jan Varga [:janv] from comment #5)
> I'm willing to rework it if we decide to just expose the thread manager.
or even the Indexed Database Manager
Assignee | ||
Comment 7•12 years ago
|
||
this adds only one tiny method to SpecialPowers
Attachment #633916 -
Flags: review?(bent.mozilla)
Updated•12 years ago
|
Attachment #633916 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Updated•12 years ago
|
Attachment #631837 -
Attachment is obsolete: true
Attachment #631837 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 8•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → mozilla16
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•